From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org, NeilBrown <neilb@suse.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH 2/2] md: raid1/raid10: initialize bvec table via bio_add_page()
Date: Thu, 13 Jul 2017 09:40:08 +0800 [thread overview]
Message-ID: <20170713014006.GD670@ming.t460p> (raw)
In-Reply-To: <20170712091608.GA27795@infradead.org>
On Wed, Jul 12, 2017 at 02:16:08AM -0700, Christoph Hellwig wrote:
> On Wed, Jul 12, 2017 at 04:29:12PM +0800, Ming Lei wrote:
> > We will support multipage bvec soon, so initialize bvec
> > table using the standardy way instead of writing the
> > talbe directly. Otherwise it won't work any more once
> > multipage bvec is enabled.
>
> It seems to me like these callsites also should use bio_init
> instead of bio_reset to get a clean slate (and eventually
> phase out bio_reset), which should probably got into
> the helper as well. E.g. instead of pretending to preserve
> things we should simply build a new bio here.
At least for resetting bvec table, bio_reset() is enough, so
I think changing to bio_init() should belong to another topic, :-)
Thanks,
Ming
next prev parent reply other threads:[~2017-07-13 1:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 8:29 [PATCH 2/2] md: raid1/raid10: initialize bvec table via bio_add_page() Ming Lei
2017-07-12 9:16 ` Christoph Hellwig
2017-07-13 1:40 ` Ming Lei [this message]
2017-07-13 0:01 ` NeilBrown
2017-07-13 1:37 ` Ming Lei
2017-07-13 3:09 ` NeilBrown
2017-07-13 9:20 ` Ming Lei
2017-07-13 16:39 ` Shaohua Li
2017-07-13 22:08 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713014006.GD670@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).