From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ming Lei Subject: Re: [PATCH 2/2] md: raid1/raid10: initialize bvec table via bio_add_page() Date: Thu, 13 Jul 2017 09:40:08 +0800 Message-ID: <20170713014006.GD670@ming.t460p> References: <20170712082912.491-1-ming.lei@redhat.com> <20170712091608.GA27795@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170712091608.GA27795@infradead.org> Sender: linux-block-owner@vger.kernel.org To: Christoph Hellwig Cc: Shaohua Li , linux-raid@vger.kernel.org, NeilBrown , linux-block@vger.kernel.org, Jens Axboe List-Id: linux-raid.ids On Wed, Jul 12, 2017 at 02:16:08AM -0700, Christoph Hellwig wrote: > On Wed, Jul 12, 2017 at 04:29:12PM +0800, Ming Lei wrote: > > We will support multipage bvec soon, so initialize bvec > > table using the standardy way instead of writing the > > talbe directly. Otherwise it won't work any more once > > multipage bvec is enabled. > > It seems to me like these callsites also should use bio_init > instead of bio_reset to get a clean slate (and eventually > phase out bio_reset), which should probably got into > the helper as well. E.g. instead of pretending to preserve > things we should simply build a new bio here. At least for resetting bvec table, bio_reset() is enough, so I think changing to bio_init() should belong to another topic, :-) Thanks, Ming