From: Ming Lei <ming.lei@redhat.com>
To: Martin Steigerwald <martin@lichtvoll.de>
Cc: Oleksandr Natalenko <oleksandr@natalenko.name>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, Shaohua Li <shli@kernel.org>
Subject: Re: I/O hangs after resuming from suspend-to-ram
Date: Mon, 25 Sep 2017 10:59:24 +0800 [thread overview]
Message-ID: <20170925025917.GA7090@ming.t460p> (raw)
In-Reply-To: <9658713.A4bv0G9Yjl@merkaba>
On Sun, Sep 24, 2017 at 07:33:00PM +0200, Martin Steigerwald wrote:
> Ming Lei - 21.09.17, 06:17:
> > On Wed, Sep 20, 2017 at 07:25:02PM +0200, Martin Steigerwald wrote:
> > > Ming Lei - 28.08.17, 21:32:
> > > > On Mon, Aug 28, 2017 at 03:10:35PM +0200, Martin Steigerwald wrote:
> > > > > Ming Lei - 28.08.17, 20:58:
> > > > > > On Sun, Aug 27, 2017 at 09:43:52AM +0200, Oleksandr Natalenko wrote:
> > > > > > > Hi.
> > >
> > > > > > > Here is disk setup for QEMU VM:
> > > […]
> > >
> > > > > > > In words: 2 virtual disks, RAID10 setup with far-2 layout, LUKS on
> > > > > > > it,
> > > > > > > then
> > > > > > > LVM, then ext4 for boot, swap and btrfs for /.
> > > > > > >
> > > > > > > I couldn't reproduce the issue with single disk without RAID.
> > > > > >
> > > > > > Could you verify if the following patch fixes your issue?
> > > > >
> > > > > Could this also apply to non MD RAID systems? I am using BTRFS RAID
> > > > > 1 with two SSDs. So far with CFQ it runs stable.
> > > >
> > > > It is for fixing Oleksandr's issue wrt. blk-mq, and looks not for you.
> > >
> > > My findings are different:
> > >
> > > On 4.12.10 with CONFIG_HZ=1000, CONFIG_PREEMPT=y and optimizations for
> > > Intel Core/newer Xeon I see this:
> > >
> > > 1) Running with CFQ: No hang after resume
> > >
> > > 2) Running with scsi_mod.use_blk_mq=1 + BFQ: Hang after resume within
> > > first 1-2 days.
> >
> > Hi Martin,
> >
> > Thanks for your report!
> >
> > Could you test the following patchset to see if it fixes your issue?
> >
> > https://marc.info/?l=linux-block&m=150579298505484&w=2
>
> Testing with https://github.com/ming1/linux.git, my_v4.13-safe-scsi-
> quiesce_V5_for_test branch as of 53954fd58fb9fe6894b1635dad1acec96ca51a2f I
> now have a bit more than three days and 8 hours of uptime without a hang on
> resume from memory or disk, despite using blk-mq + BFQ.
>
> So it looks like this patch set fixes the issue for me. To say for sure I´d say
> some more days of testing are needed. But it looks like the hang on resume is
> fixed by this patch set.
Martin, thanks for your test, it is great to see your issue is fixed
by this patchset.
Also I remember that your issue wasn't related with MD, and actually
you were using BTRFS(RAID), just want to double check with you,
is that true?
--
Ming
next prev parent reply other threads:[~2017-09-25 2:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 11:45 I/O hangs after resuming from suspend-to-ram Oleksandr Natalenko
2017-08-26 10:37 ` Oleksandr Natalenko
2017-08-26 10:48 ` Oleksandr Natalenko
2017-08-26 11:19 ` Martin Steigerwald
2017-08-26 17:17 ` Wols Lists
2017-08-26 19:33 ` Martin Steigerwald
2017-08-26 13:32 ` Oleksandr Natalenko
2017-08-27 6:02 ` Ming Lei
2017-08-27 7:43 ` Oleksandr Natalenko
2017-08-28 12:58 ` Ming Lei
2017-08-28 13:10 ` Martin Steigerwald
2017-08-28 13:32 ` Ming Lei
2017-09-20 17:25 ` Martin Steigerwald
2017-09-20 22:17 ` Ming Lei
2017-09-24 17:33 ` Martin Steigerwald
2017-09-25 2:59 ` Ming Lei [this message]
2017-09-25 14:13 ` Martin Steigerwald
2017-09-20 22:20 ` Ming Lei
2017-09-21 7:30 ` Martin Steigerwald
2017-09-21 7:33 ` Martin Steigerwald
2017-08-28 18:22 ` Oleksandr Natalenko
2017-08-29 0:24 ` Ming Lei
2017-08-29 15:52 ` Oleksandr Natalenko
2017-08-30 2:15 ` Ming Lei
2017-08-30 5:17 ` Ming Lei
2017-08-30 6:15 ` oleksandr
2017-08-30 8:06 ` Ming Lei
2017-08-30 10:58 ` oleksandr
2017-08-30 14:37 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925025917.GA7090@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin@lichtvoll.de \
--cc=oleksandr@natalenko.name \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).