From: Wakko Warner <wakko@animx.eu.org>
To: Phil Turmel <philip@turmel.org>
Cc: NeilBrown <neilb@suse.com>, John Stoffel <john@stoffel.org>,
Eli Ben-Shoshan <eli@benshoshan.com>,
Jes.Sorensen@gmail.com, linux-raid@vger.kernel.org
Subject: Re: mdadm: Patch to restrict --size when shrinking unless forced
Date: Mon, 9 Oct 2017 20:07:02 -0400 [thread overview]
Message-ID: <20171010000702.GA6038@animx.eu.org> (raw)
In-Reply-To: <c476e0a8-ff57-e38d-f3d7-0c59242cc0b9@turmel.org>
Phil Turmel wrote:
> On 10/09/2017 12:10 AM, NeilBrown wrote:
>
> > If there is some action that mdadm can currently be told to perform, and
> > when it tries to perform that action it corrupts the array, then
> > it is certainly appropriate to teach mdadm not to perform that action.
> > It shouldn't even perform that action with --force. I agree that
> > changing mdadm like this is complementary to changing the kernel. Both
> > are useful.
>
> A certain amount of the trouble with all of this is the english meaning
> of "grow" doesn't really match what mdadm allows.
>
> Might it be reasonable to reject "--grow" operations that reduce the
> final array size, and introduce the complementary "--reduce" operation
> that rejects array size increases?
>
> Both operations would share the current code, just apply a different
> sanity check before proceeding.
>
> mdadm would then at least not violate the rule of least surprise.
As a general user of md raid and as a reader of the list, I would agree that
this would be a better solution. Thinking in terms of lvm, there's lvreduce
and lvextend. IMO, --force wouldn't be needed for --reduce (I was orginally
thinking of --shrink)
On a side note, is it possible for the lower layers to know what the last
used sector is? IE lvm ontop of raid and has 10% allocated and the last
sector is around the 10% mark. (If this were possible --force would be,
required if shrinking would result in inaccessible data)
I recently did a shrink of 4x 2tb drives so that I could replace the 2tb
drives with 80gb drives (yes, big shrink!) Would have been nice for mdadm
to know the smallest size was that wouldn't destroy my lvm volumes that were
on top.
--
Microsoft has beaten Volkswagen's world record. Volkswagen only created 22
million bugs.
next prev parent reply other threads:[~2017-10-10 0:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:00 mdadm: Patch to restrict --size when shrinking unless forced John Stoffel
2017-10-04 18:11 ` Jes Sorensen
2017-10-04 19:15 ` John Stoffel
2017-10-04 19:23 ` Jes Sorensen
2017-10-04 19:33 ` John Stoffel
2017-10-04 21:50 ` NeilBrown
2017-10-05 1:26 ` John Stoffel
2017-10-07 22:06 ` Wols Lists
2017-10-07 22:17 ` John Stoffel
2017-10-07 22:37 ` Wols Lists
2017-10-07 22:46 ` John Stoffel
2017-10-08 20:57 ` John Stoffel
2017-10-08 22:52 ` NeilBrown
2017-10-09 1:18 ` John Stoffel
2017-10-09 1:36 ` NeilBrown
2017-10-09 1:22 ` John Stoffel
2017-10-09 4:10 ` NeilBrown
2017-10-09 20:04 ` Phil Turmel
2017-10-10 0:07 ` Wakko Warner [this message]
2017-10-10 13:12 ` Phil Turmel
2017-10-10 20:52 ` NeilBrown
2017-10-10 20:55 ` Wakko Warner
2017-10-10 2:01 ` John Stoffel
2017-10-10 20:09 ` Jes Sorensen
2017-10-10 20:54 ` Wols Lists
2017-10-10 21:07 ` Jes Sorensen
2017-10-10 20:48 ` NeilBrown
2017-10-10 20:58 ` Phil Turmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010000702.GA6038@animx.eu.org \
--to=wakko@animx.eu.org \
--cc=Jes.Sorensen@gmail.com \
--cc=eli@benshoshan.com \
--cc=john@stoffel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=philip@turmel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).