* [PATCH] dmraid: remove partitions with O_RDONLY
@ 2017-10-26 20:47 Martin Wilck
0 siblings, 0 replies; only message in thread
From: Martin Wilck @ 2017-10-26 20:47 UTC (permalink / raw)
To: Heinz Mauelshagen
Cc: dm-devel, Martin Wilck, linux-raid, Neil Brown, Hannes Reinecke
It's not necessary to use O_RDWR to use BLKPG_DEL_PARTITION.
It's actually harmful, because closing the device will cause
an IN_CLOSE_WRITE inotify event, which will trigger a BLKRRPART
from systemd, which will reinstate all partitions just deleted.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
lib/device/partition.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/device/partition.c b/lib/device/partition.c
index 9352b0437694..a01cc3583514 100644
--- a/lib/device/partition.c
+++ b/lib/device/partition.c
@@ -22,7 +22,7 @@ _remove_subset_partitions(struct lib_context *lc, struct raid_set *rs)
};
list_for_each_entry(rd, &rs->devs, devs) {
- int fd = open(rd->di->path, O_RDWR);
+ int fd = open(rd->di->path, O_RDONLY);
if (fd < 0)
LOG_ERR(lc, 0, "opening %s: %s\n", rd->di->path,
strerror(errno));
--
2.14.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-10-26 20:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-26 20:47 [PATCH] dmraid: remove partitions with O_RDONLY Martin Wilck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).