From: Kent Overstreet <kent.overstreet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Liu Bo <obuil.liubo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 1/6] Generic radix trees
Date: Sat, 26 May 2018 01:56:01 -0400 [thread overview]
Message-ID: <20180526055601.GA26155@kmo-pixel> (raw)
In-Reply-To: <CANQeFDCLc56thuuGYBMdb_qvw_O=t7sLkJiP-LNYfKwgz74H_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Sat, May 26, 2018 at 11:16:42AM +0800, Liu Bo wrote:
> > +/*
> > + * Returns pointer to the specified byte @offset within @radix, allocating it if
> > + * necessary - newly allocated slots are always zeroed out:
> > + */
> > +void *__genradix_ptr_alloc(struct __genradix *radix, size_t offset,
> > + gfp_t gfp_mask)
> > +{
> > + struct genradix_node **n;
>
> Any reason that " struct genradix_node ** " is used here instead of "
> struct genradix_node * "?
>
> Looks like this function only manipulates *n, am I missing something?
It stores to *n, when it has to allocate a node (including the root)
next prev parent reply other threads:[~2018-05-26 5:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 1:18 [PATCH 1/6] Generic radix trees Kent Overstreet
[not found] ` <20180523011821.12165-1-kent.overstreet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-05-23 1:18 ` [PATCH 2/6] proc: commit to genradix Kent Overstreet
2018-05-23 11:28 ` Matthew Wilcox
[not found] ` <20180523112823.GA19987-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2018-05-23 22:18 ` Kent Overstreet
2018-05-26 3:16 ` [PATCH 1/6] Generic radix trees Liu Bo
[not found] ` <CANQeFDCLc56thuuGYBMdb_qvw_O=t7sLkJiP-LNYfKwgz74H_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-05-26 5:56 ` Kent Overstreet [this message]
2018-05-29 1:48 ` Liu Bo
2018-05-23 1:18 ` [PATCH 3/6] md: convert to genradix Kent Overstreet
2018-05-23 1:18 ` [PATCH 4/6] openvswitch: " Kent Overstreet
2018-05-23 12:34 ` Matthew Wilcox
[not found] ` <20180523123401.GB19987-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2018-05-23 22:24 ` Kent Overstreet
2018-05-23 1:18 ` [PATCH 5/6] selinux: " Kent Overstreet
2018-05-23 1:18 ` [PATCH 6/6] Drop flex_arrays Kent Overstreet
[not found] ` <20180523011821.12165-6-kent.overstreet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-05-23 13:39 ` Jonathan Corbet
2018-05-23 17:24 ` Dave Hansen
[not found] ` <0fb1b28b-12da-5d2b-2308-283af9fe6ae4-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-05-23 22:06 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180526055601.GA26155@kmo-pixel \
--to=kent.overstreet-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=obuil.liubo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org \
--cc=shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
--cc=willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).