linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
	linux-raid@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Yury Norov <ynorov@caviumnetworks.com>,
	linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 1/5] md: Avoid namespace collision with bitmap API
Date: Fri, 15 Jun 2018 23:19:23 +0800	[thread overview]
Message-ID: <201806152116.mTkT1ANS%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180615132017.23889-2-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2589 bytes --]

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20180615]
[also build test ERROR on v4.17]
[cannot apply to md/for-next linus/master dm/for-next v4.17 v4.17-rc7 v4.17-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/bitmap-Introduce-alloc-free-helpers/20180615-214724
config: x86_64-randconfig-x008-201823 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/md/persistent-data/dm-space-map-common.c:111:23: error: 'bitmap_prepare_for_write' undeclared here (not in a function); did you mean 'md_bitmap_prepare_for_write'?
     .prepare_for_write = bitmap_prepare_for_write,
                          ^~~~~~~~~~~~~~~~~~~~~~~~
                          md_bitmap_prepare_for_write
>> drivers/md/persistent-data/dm-space-map-common.c:112:11: error: 'bitmap_check' undeclared here (not in a function); did you mean 'md_bitmap_check'?
     .check = bitmap_check
              ^~~~~~~~~~~~
              md_bitmap_check
   drivers/md/persistent-data/dm-space-map-common.c:84:12: warning: 'md_bitmap_check' defined but not used [-Wunused-function]
    static int md_bitmap_check(struct dm_block_validator *v,
               ^~~~~~~~~~~~~~~
   drivers/md/persistent-data/dm-space-map-common.c:72:13: warning: 'md_bitmap_prepare_for_write' defined but not used [-Wunused-function]
    static void md_bitmap_prepare_for_write(struct dm_block_validator *v,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +111 drivers/md/persistent-data/dm-space-map-common.c

3241b1d3 Joe Thornber 2011-10-31  108  
3241b1d3 Joe Thornber 2011-10-31  109  static struct dm_block_validator dm_sm_bitmap_validator = {
3241b1d3 Joe Thornber 2011-10-31  110  	.name = "sm_bitmap",
3241b1d3 Joe Thornber 2011-10-31 @111  	.prepare_for_write = bitmap_prepare_for_write,
3241b1d3 Joe Thornber 2011-10-31 @112  	.check = bitmap_check
3241b1d3 Joe Thornber 2011-10-31  113  };
3241b1d3 Joe Thornber 2011-10-31  114  

:::::: The code at line 111 was first introduced by commit
:::::: 3241b1d3e0aaafbfcd320f4d71ade629728cc4f4 dm: add persistent data library

:::::: TO: Joe Thornber <thornber@redhat.com>
:::::: CC: Alasdair G Kergon <agk@redhat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27635 bytes --]

  parent reply	other threads:[~2018-06-15 15:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 13:20 [PATCH v2 0/5] bitmap: Introduce alloc/free helpers Andy Shevchenko
2018-06-15 13:20 ` [PATCH v2 1/5] md: Avoid namespace collision with bitmap API Andy Shevchenko
2018-06-15 15:09   ` kbuild test robot
2018-06-15 14:58     ` Andy Shevchenko
2018-06-18 13:36       ` Mike Snitzer
2018-06-15 15:19   ` kbuild test robot [this message]
2018-06-15 13:20 ` [PATCH v2 2/5] bitmap: Drop unnecessary 0 check for u32 array operations Andy Shevchenko
2018-06-15 13:20 ` [PATCH v2 3/5] bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free() Andy Shevchenko
2018-06-15 22:23   ` Yury Norov
2018-06-16 18:42     ` Andy Shevchenko
2018-06-15 13:20 ` [PATCH v2 4/5] Input: gpio-keys - Switch to bitmap_zalloc() Andy Shevchenko
2018-06-15 22:06   ` Yury Norov
2018-06-16 18:50     ` Andy Shevchenko
2018-06-15 13:20 ` [PATCH v2 5/5] Input: evdev " Andy Shevchenko
2018-06-15 21:42   ` Yury Norov
2018-06-16 18:45     ` Andy Shevchenko
2018-06-16 19:16       ` Joe Perches
2018-06-18 12:02         ` Andy Shevchenko
2018-06-18 15:49           ` Joe Perches
2018-06-18 19:56             ` Andy Shevchenko
2018-06-18 20:40               ` Joe Perches
2018-06-19 18:33     ` Dmitry Torokhov
2018-06-20  8:13       ` Yury Norov
2018-06-20 20:26         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201806152116.mTkT1ANS%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dm-devel@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=shli@kernel.org \
    --cc=snitzer@redhat.com \
    --cc=ynorov@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).