From: Christoph Hellwig <hch@infradead.org>
To: Guilherme Piccoli <gpiccoli@canonical.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org,
linux-raid <linux-raid@vger.kernel.org>,
dm-devel@redhat.com, axboe@kernel.dk,
Gavin Guo <gavin.guo@canonical.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>,
"Guilherme G. Piccoli" <kernel@gpiccoli.net>,
Ming Lei <ming.lei@redhat.com>, Song Liu <liu.song.a23@gmail.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
stable@vger.kernel.org
Subject: Re: [PATCH V2 2/2] md/raid0: Do not bypass blocking queue entered for raid0 bios
Date: Tue, 21 May 2019 10:22:58 -0700 [thread overview]
Message-ID: <20190521172258.GA32702@infradead.org> (raw)
In-Reply-To: <CAHD1Q_z23AO+NRid1xYTeke_5GAe6hPianEZKBf5P30FrfZGFg@mail.gmail.com>
On Tue, May 21, 2019 at 11:10:05AM -0300, Guilherme Piccoli wrote:
> Hi Christoph, thanks for looking into this.
> You're right, this series fixes both issues. The problem I see though
> is that it relies
> on legacy IO path removal - for v5.0 and beyond, all fine. But
> backporting that to
> v4.17-v4.20 stable series will be quite painful.
>
> My fixes are mostly "oneliners". If we could get both approaches upstream,
> that'd be perfect!
But they basically just fix code that otherwise gets removed. And the way
this patches uses the ENTERED flag from the md code looks slightly
sketchy to me. Maybe we want them as stable only patches.
next prev parent reply other threads:[~2019-05-21 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 22:09 [PATCH V2 1/2] block: Fix a NULL pointer dereference in generic_make_request() Guilherme G. Piccoli
2019-05-20 22:09 ` [PATCH V2 2/2] md/raid0: Do not bypass blocking queue entered for raid0 bios Guilherme G. Piccoli
2019-05-21 12:56 ` Christoph Hellwig
2019-05-21 14:10 ` Guilherme Piccoli
2019-05-21 17:22 ` Christoph Hellwig [this message]
2019-05-21 17:37 ` Guilherme Piccoli
2019-05-21 5:59 ` [PATCH V2 1/2] block: Fix a NULL pointer dereference in generic_make_request() Song Liu
2019-05-21 12:07 ` Guilherme Piccoli
2019-05-23 14:33 ` Guilherme G. Piccoli
2019-05-23 17:06 ` Song Liu
2019-05-23 20:30 ` Guilherme Piccoli
2019-05-21 12:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521172258.GA32702@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=gavin.guo@canonical.com \
--cc=gpiccoli@canonical.com \
--cc=jay.vosburgh@canonical.com \
--cc=kernel@gpiccoli.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=ming.lei@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).