From: Christoph Hellwig <hch@infradead.org>
To: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
Cc: axboe@kernel.dk, song@kernel.org, linux-block@vger.kernel.org,
linux-raid@vger.kernel.org,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Subject: Re: [PATCH 2/2] md: enable io polling
Date: Thu, 30 Jan 2020 22:36:53 -0800 [thread overview]
Message-ID: <20200131063653.GD6267@infradead.org> (raw)
In-Reply-To: <20200126044138.5066-3-andrzej.jakowski@linux.intel.com>
> + rdev_for_each(rdev, mddev) {
> + if (rdev->raid_disk >= 0 && !test_bit(Faulty, &rdev->flags)) {
> + rv = blk_poll(bdev_get_queue(rdev->bdev), cookie, false);
This adds a > 80 char line. But if you just use a continue to skip
the not allicable ones you even clean up the code while avoiding that.
prev parent reply other threads:[~2020-01-31 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 4:41 [PATCH 0/2] Enable polling on stackable devices Andrzej Jakowski
2020-01-26 4:41 ` [PATCH 1/2] block: introduce polling on bio level Andrzej Jakowski
2020-01-30 4:01 ` Jens Axboe
2020-01-31 6:35 ` Christoph Hellwig
2020-02-01 4:41 ` Jens Axboe
2020-01-31 6:34 ` Christoph Hellwig
2020-01-31 18:51 ` Andrzej Jakowski
2020-02-01 8:20 ` Christoph Hellwig
2020-01-26 4:41 ` [PATCH 2/2] md: enable io polling Andrzej Jakowski
2020-01-31 6:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131063653.GD6267@infradead.org \
--to=hch@infradead.org \
--cc=andrzej.jakowski@linux.intel.com \
--cc=artur.paszkiewicz@intel.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).