* [PATCH] udev: Ignore change event for imsm
@ 2020-04-08 14:44 Mariusz Tkaczyk
2020-04-27 14:23 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Tkaczyk @ 2020-04-08 14:44 UTC (permalink / raw)
To: jes; +Cc: linux-raid
When adding a device to a container mdadm has to close its file
descriptor before sysfs_add_disk(). This generates change event.
There is race possibility because metadata is already written and other
-I process can place drive differently. As a result device can be added
to two containers simultaneously.
From IMSM perspective there is no need to react for change event. IMSM
doesn't support stacked devices.
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@intel.com>
---
udev-md-raid-assembly.rules | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/udev-md-raid-assembly.rules b/udev-md-raid-assembly.rules
index 9f055ed0..d668cddd 100644
--- a/udev-md-raid-assembly.rules
+++ b/udev-md-raid-assembly.rules
@@ -23,7 +23,7 @@ IMPORT{cmdline}="nodmraid"
ENV{nodmraid}=="?*", GOTO="md_inc_end"
ENV{ID_FS_TYPE}=="ddf_raid_member", GOTO="md_inc"
ENV{noiswmd}=="?*", GOTO="md_inc_end"
-ENV{ID_FS_TYPE}=="isw_raid_member", GOTO="md_inc"
+ENV{ID_FS_TYPE}=="isw_raid_member", ACTION!="change", GOTO="md_inc"
GOTO="md_inc_end"
LABEL="md_inc"
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] udev: Ignore change event for imsm
2020-04-08 14:44 [PATCH] udev: Ignore change event for imsm Mariusz Tkaczyk
@ 2020-04-27 14:23 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2020-04-27 14:23 UTC (permalink / raw)
To: Mariusz Tkaczyk; +Cc: linux-raid
On 4/8/20 10:44 AM, Mariusz Tkaczyk wrote:
> When adding a device to a container mdadm has to close its file
> descriptor before sysfs_add_disk(). This generates change event.
> There is race possibility because metadata is already written and other
> -I process can place drive differently. As a result device can be added
> to two containers simultaneously.
> From IMSM perspective there is no need to react for change event. IMSM
> doesn't support stacked devices.
>
> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@intel.com>
> ---
> udev-md-raid-assembly.rules | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-27 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-08 14:44 [PATCH] udev: Ignore change event for imsm Mariusz Tkaczyk
2020-04-27 14:23 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).