Re: [PATCH v5 01/16] md/raid456: covert macro define of STRIPE_* as members of struct r5conf

antlists
2020-07-12T22:55:14Z

On 02/07/2020 19:23, Paul Menzel wrote:
> Dear Yufen,
>
>
> Am 02.07.20 um 20:15 schrieb Song Liu:
>> On Thu, Jul 2, 2020 at 5:05 AM Yufen Yu <yuyufen@huawei.com> wrote:
>>>
>>> We covert STRIPE_SIZE, STRIPE_SHIFT and STRIPE_SECTORS to stripe_size,
>>> stripe_shift and stripe_sectors as members of struct r5conf. Then each
>>> raid456 array can config different stripe_size. This patch is prepared
>>> for following configurable stripe_size.
>>>
>>> Simply replace word STRIPE_ with conf->stripe_ and add 'conf' argument
>>> for function stripe_hash_locks_hash() and r5_next_bio() to get
>>> stripe_size.
>>> After that, we initialize stripe_size into setup_conf().
>>>
>>> Signed-off-by: Yufen Yu <yuyufen@huawei.com>
>>
>> This patch looks good. Please fix the warning found by the kernel test
>> bot.
>> Also a nitpick below.
>
> Please also fix the typo *covert* to *Convert* in the commit message
> summary, and maybe use *to* instead of *as*.

Actually, if I understand the Pidgin correctly, "as" is correct grammar.
"to" just doesn't work for me ...
>
> > Convert macro define of STRIPE_* to members of struct r5conf
>
Cheers,
Wol