From: kernel test robot <lkp@intel.com>
To: Xiao Ni <xni@redhat.com>
Cc: kbuild-all@lists.01.org, linux-raid@vger.kernel.org,
Song Liu <songliubraving@fb.com>, Coly Li <colyli@suse.de>,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Subject: [PATCH] md/raid10: fix boolreturn.cocci warnings
Date: Tue, 22 Sep 2020 08:30:44 +0800 [thread overview]
Message-ID: <20200922003044.GA8898@8d4990752b6e> (raw)
In-Reply-To: <202009220853.dnMV3qcl%lkp@intel.com>
From: kernel test robot <lkp@intel.com>
drivers/md/raid10.c:1763:8-9: WARNING: return of 0/1 in function 'raid10_handle_discard' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 8f694215ae4c ("md/raid10: improve raid10 discard request")
CC: Xiao Ni <xni@redhat.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
head: 5b2374a6c221f28c74913d208bb5376a7ee3bf70
commit: 8f694215ae4c7abf1e6c985803a1aad0db748d07 [15/16] md/raid10: improve raid10 discard request
raid10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1760,7 +1760,7 @@ static bool raid10_handle_discard(struct
raid_end_bio_io(r10_bio);
}
- return 0;
+ return false;
out:
allow_barrier(conf);
return -EAGAIN;
next prev parent reply other threads:[~2020-09-22 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 0:30 [song-md:md-next 15/16] drivers/md/raid10.c:1763:8-9: WARNING: return of 0/1 in function 'raid10_handle_discard' with return type bool kernel test robot
2020-09-22 0:30 ` kernel test robot [this message]
2020-09-22 5:48 ` [PATCH] md/raid10: fix boolreturn.cocci warnings Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922003044.GA8898@8d4990752b6e \
--to=lkp@intel.com \
--cc=colyli@suse.de \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-raid@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).