From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99AA7C388F9 for ; Mon, 26 Oct 2020 17:52:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50FC32072D for ; Mon, 26 Oct 2020 17:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603734755; bh=KFtu/NZNvgNe6TTGzBuUKpV14ikFgvjMFkZhl1sUIDg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ioWcIoInSaPDVIybsqYjymtUpJ4ekwBySqqxWcC/Dk+1GT3ESYSBoHohio9teIgdm 8lDJZxY69YAuYb1aag8ziQMq+IcOQEZdYHlBSPySg4vZTX16e3Z1tJ1vI7DjSZEEwU 3FZn3inR5s9c5H145sSoc7YmLM9y+hStgYo6MS+U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1788572AbgJZRwe (ORCPT ); Mon, 26 Oct 2020 13:52:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:44842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1788565AbgJZRwd (ORCPT ); Mon, 26 Oct 2020 13:52:33 -0400 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C592020790; Mon, 26 Oct 2020 17:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603734753; bh=KFtu/NZNvgNe6TTGzBuUKpV14ikFgvjMFkZhl1sUIDg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fzrH56fSrUIOoyFYI+1aFazvExThzR1aHA4Av7NPY3zN3ebfvdu4fJqU3KZkXJS9H vkbdy7g4v//mzg/0gJ+wH2gC9BoAJOZ4Nuh7ECj560RYjOZzAsRHV1bZaj54aLcUjk 1lqxtsGk7nXiN4m7N6JdKhbo38El8wgaEZQQxqmQ= Date: Mon, 26 Oct 2020 10:52:31 -0700 From: Eric Biggers To: Gilad Ben-Yossef Cc: Herbert Xu , "David S. Miller" , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Song Liu , Ofir Drang , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 3/4] dm crypt: switch to EBOIV crypto API template Message-ID: <20201026175231.GG858@sol.localdomain> References: <20201026130450.6947-1-gilad@benyossef.com> <20201026130450.6947-4-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026130450.6947-4-gilad@benyossef.com> Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Mon, Oct 26, 2020 at 03:04:46PM +0200, Gilad Ben-Yossef wrote: > Replace the explicit EBOIV handling in the dm-crypt driver with calls > into the crypto API, which now possesses the capability to perform > this processing within the crypto subsystem. > > Signed-off-by: Gilad Ben-Yossef > > --- > drivers/md/Kconfig | 1 + > drivers/md/dm-crypt.c | 61 ++++++++++++++----------------------------- > 2 files changed, 20 insertions(+), 42 deletions(-) > > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > index 30ba3573626c..ca6e56a72281 100644 > --- a/drivers/md/Kconfig > +++ b/drivers/md/Kconfig > @@ -273,6 +273,7 @@ config DM_CRYPT > select CRYPTO > select CRYPTO_CBC > select CRYPTO_ESSIV > + select CRYPTO_EBOIV > help > This device-mapper target allows you to create a device that > transparently encrypts the data on it. You'll need to activate Can CRYPTO_EBOIV please not be selected by default? If someone really wants Bitlocker compatibility support, they can select this option themselves. - Eric