From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Tejun Heo <tj@kernel.org>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-raid@vger.kernel.org, linux-s390@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 1/5] block: remove the unused block_sleeprq tracepoint
Date: Thu, 3 Dec 2020 17:21:35 +0100 [thread overview]
Message-ID: <20201203162139.2110977-2-hch@lst.de> (raw)
In-Reply-To: <20201203162139.2110977-1-hch@lst.de>
The block_sleeprq tracepoint was only used by the legacy request code.
Remove it now that the legacy request code is gone.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
include/trace/events/block.h | 18 ------------------
kernel/trace/blktrace.c | 22 ----------------------
2 files changed, 40 deletions(-)
diff --git a/include/trace/events/block.h b/include/trace/events/block.h
index 34d64ca306b1c7..76459cf750e14d 100644
--- a/include/trace/events/block.h
+++ b/include/trace/events/block.h
@@ -441,24 +441,6 @@ DEFINE_EVENT(block_get_rq, block_getrq,
TP_ARGS(q, bio, rw)
);
-/**
- * block_sleeprq - waiting to get a free request entry in queue for block IO operation
- * @q: queue for operation
- * @bio: pending block IO operation (can be %NULL)
- * @rw: low bit indicates a read (%0) or a write (%1)
- *
- * In the case where a request struct cannot be provided for queue @q
- * the process needs to wait for an request struct to become
- * available. This tracepoint event is generated each time the
- * process goes to sleep waiting for request struct become available.
- */
-DEFINE_EVENT(block_get_rq, block_sleeprq,
-
- TP_PROTO(struct request_queue *q, struct bio *bio, int rw),
-
- TP_ARGS(q, bio, rw)
-);
-
/**
* block_plug - keep operations requests in request queue
* @q: request queue to plug
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index a482a37848bff7..ced589df304b57 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -959,25 +959,6 @@ static void blk_add_trace_getrq(void *ignore,
}
}
-
-static void blk_add_trace_sleeprq(void *ignore,
- struct request_queue *q,
- struct bio *bio, int rw)
-{
- if (bio)
- blk_add_trace_bio(q, bio, BLK_TA_SLEEPRQ, 0);
- else {
- struct blk_trace *bt;
-
- rcu_read_lock();
- bt = rcu_dereference(q->blk_trace);
- if (bt)
- __blk_add_trace(bt, 0, 0, rw, 0, BLK_TA_SLEEPRQ,
- 0, 0, NULL, 0);
- rcu_read_unlock();
- }
-}
-
static void blk_add_trace_plug(void *ignore, struct request_queue *q)
{
struct blk_trace *bt;
@@ -1164,8 +1145,6 @@ static void blk_register_tracepoints(void)
WARN_ON(ret);
ret = register_trace_block_getrq(blk_add_trace_getrq, NULL);
WARN_ON(ret);
- ret = register_trace_block_sleeprq(blk_add_trace_sleeprq, NULL);
- WARN_ON(ret);
ret = register_trace_block_plug(blk_add_trace_plug, NULL);
WARN_ON(ret);
ret = register_trace_block_unplug(blk_add_trace_unplug, NULL);
@@ -1185,7 +1164,6 @@ static void blk_unregister_tracepoints(void)
unregister_trace_block_split(blk_add_trace_split, NULL);
unregister_trace_block_unplug(blk_add_trace_unplug, NULL);
unregister_trace_block_plug(blk_add_trace_plug, NULL);
- unregister_trace_block_sleeprq(blk_add_trace_sleeprq, NULL);
unregister_trace_block_getrq(blk_add_trace_getrq, NULL);
unregister_trace_block_bio_queue(blk_add_trace_bio_queue, NULL);
unregister_trace_block_bio_frontmerge(blk_add_trace_bio_frontmerge, NULL);
--
2.29.2
next prev parent reply other threads:[~2020-12-03 16:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 16:21 block tracepoint cleanups v2 Christoph Hellwig
2020-12-03 16:21 ` Christoph Hellwig [this message]
2020-12-03 19:45 ` [PATCH 1/5] block: remove the unused block_sleeprq tracepoint Tejun Heo
2020-12-04 3:25 ` Chaitanya Kulkarni
2020-12-03 16:21 ` [PATCH 2/5] block: simplify and extend the block_bio_merge tracepoint class Christoph Hellwig
2020-12-03 20:05 ` Tejun Heo
2020-12-04 3:25 ` Chaitanya Kulkarni
2020-12-03 16:21 ` [PATCH 3/5] block: remove the request_queue argument to the block_split tracepoint Christoph Hellwig
2020-12-03 20:06 ` Tejun Heo
2020-12-04 3:26 ` Chaitanya Kulkarni
2020-12-03 16:21 ` [PATCH 4/5] block: remove the request_queue argument to the block_bio_remap tracepoint Christoph Hellwig
2020-12-03 20:07 ` Tejun Heo
2020-12-04 3:27 ` Chaitanya Kulkarni
2020-12-03 16:21 ` [PATCH 5/5] block: remove the request_queue to argument request based tracepoints Christoph Hellwig
2020-12-03 20:10 ` Tejun Heo
2020-12-04 3:26 ` Chaitanya Kulkarni
2020-12-04 16:42 ` block tracepoint cleanups v2 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-11-30 17:58 block tracepoint cleanups Christoph Hellwig
2020-11-30 17:58 ` [PATCH 1/5] block: remove the unused block_sleeprq tracepoint Christoph Hellwig
2020-12-03 12:43 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203162139.2110977-2-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).