From: Christoph Hellwig <hch@infradead.org>
To: Zhao Heming <heming.zhao@suse.com>
Cc: linux-raid@vger.kernel.org, song@kernel.org,
guoqing.jiang@cloud.ionos.com, lidong.zhong@suse.com,
xni@redhat.com, neilb@suse.de, colyli@suse.com
Subject: Re: [PATCH] md: don't create mddev in md_open
Date: Wed, 31 Mar 2021 07:55:12 +0100 [thread overview]
Message-ID: <20210331065512.GA987842@infradead.org> (raw)
In-Reply-To: <1617090209-18648-1-git-send-email-heming.zhao@suse.com>
> -static struct mddev *mddev_find(dev_t unit)
> +static struct mddev *mddev_find(dev_t unit, bool create)
This just makes the mess that is mddev_find even worse. Please take
a look at the patches at the beginning of the
"move bd_mutex to the gendisk"
series to try to clean this up properly.
next prev parent reply other threads:[~2021-03-31 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 7:43 [PATCH] md: don't create mddev in md_open Zhao Heming
2021-03-30 8:28 ` heming.zhao
2021-03-31 6:55 ` Christoph Hellwig [this message]
2021-03-31 16:42 ` heming.zhao
2021-03-31 22:46 ` Song Liu
2021-04-01 0:43 ` heming.zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331065512.GA987842@infradead.org \
--to=hch@infradead.org \
--cc=colyli@suse.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=heming.zhao@suse.com \
--cc=lidong.zhong@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=song@kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox