From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C5EC433B4 for ; Sat, 3 Apr 2021 16:12:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9178B610F7 for ; Sat, 3 Apr 2021 16:12:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236426AbhDCQME (ORCPT ); Sat, 3 Apr 2021 12:12:04 -0400 Received: from verein.lst.de ([213.95.11.211]:46628 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230450AbhDCQME (ORCPT ); Sat, 3 Apr 2021 12:12:04 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id E9A6268BEB; Sat, 3 Apr 2021 18:11:58 +0200 (CEST) Date: Sat, 3 Apr 2021 18:11:58 +0200 From: Christoph Hellwig To: Zhao Heming Cc: linux-raid@vger.kernel.org, song@kernel.org, hch@lst.de, guoqing.jiang@cloud.ionos.com, lidong.zhong@suse.com, xni@redhat.com, neilb@suse.de, colyli@suse.com Subject: Re: [PATCH] md: md_open returns -EBUSY when entering racing area Message-ID: <20210403161158.GA4657@lst.de> References: <1617418885-23423-1-git-send-email-heming.zhao@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617418885-23423-1-git-send-email-heming.zhao@suse.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org This defintively looks better than the ERESTARTSYS hack. I think I'll defer the whole blkdev_get refactoring and bd_mutex to open_mutex conversion to the next merge window, so I think we should be fine with this plus the mddev_find split. Reviewed-by: Christoph Hellwig