From: markus@hochholdinger.net
To: song@kernel.org, linux-raid@vger.kernel.org, xni@redhat.com
Cc: Markus Hochholdinger <markus@hochholdinger.net>
Subject: [PATCH] md: fix update super 1.0 on rdev size change
Date: Fri, 12 Nov 2021 14:28:22 +0000 [thread overview]
Message-ID: <20211112142822.813606-1-markus@hochholdinger.net> (raw)
From: Markus Hochholdinger <markus@hochholdinger.net>
The superblock of version 1.0 doesn't get moved to the new position on a
device size change. This leads to a rdev without a superblock on a known
position, the raid can't be re-assembled.
Fixes: commit d9c0fa509eaf ("md: fix max sectors calculation for super 1.0")
---
drivers/md/md.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 6c0c3d0d905a..ad968cfc883d 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -2193,6 +2193,7 @@ super_1_rdev_size_change(struct md_rdev *rdev, sector_t num_sectors)
if (!num_sectors || num_sectors > max_sectors)
num_sectors = max_sectors;
+ rdev->sb_start = sb_start;
}
sb = page_address(rdev->sb_page);
sb->data_size = cpu_to_le64(num_sectors);
--
2.30.2
next reply other threads:[~2021-11-12 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:28 markus [this message]
2021-11-15 9:47 ` [PATCH] md: fix update super 1.0 on rdev size change Xiao Ni
2021-11-15 18:39 ` Markus Hochholdinger
2021-11-15 20:07 ` Wol
2021-11-16 8:35 ` Xiao Ni
2021-11-16 7:53 ` Xiao Ni
2021-11-16 9:28 ` Markus Hochholdinger
2021-11-16 16:41 ` Wols Lists
2021-11-16 8:36 ` Xiao Ni
2021-11-16 9:24 ` Paul Menzel
2021-11-16 9:44 ` Markus Hochholdinger
2021-11-16 9:52 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112142822.813606-1-markus@hochholdinger.net \
--to=markus@hochholdinger.net \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox