linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* mdadm regression tests fail
       [not found] <c4c17b11-16f4-ef70-5897-02f923907963@gmail.com>
@ 2022-01-05  3:07 ` Bruce Dubbs
  2022-01-05 17:12 ` Randy Dunlap
  1 sibling, 0 replies; 5+ messages in thread
From: Bruce Dubbs @ 2022-01-05  3:07 UTC (permalink / raw)
  To: linux-raid@vger.kernel.org

I am trying to document the mdadm-4.2 installation procedures for our book,
https://www.linuxfromscratch.org/blfs/view/svn/postlfs/mdadm.html

For testing, I am doing a simple:

    make
    sudo ./test --keep-going --logdir=test-logs --save-logs

But I get failures for about half the tests.

Digging in a bit I just ran:

   sudo ./test --tests=00raid0 --logdir=test-logs

This is the first test that fails.  With some hacking, it appears that the first
portion of this test that fails is:

     mdadm -CR $md0 -e0.90 -l0 -n4 $dev0 $dev1 $dev2 $dev3

This resolves to

     mdadm -CR /dev/md0 -e0.90 -l0 -n4 /dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3

There is not a lot of error output in the test, so I manually ran:

     dd if=/dev/zero of=/tmp/mdtest0 count=20000 bs=1K
     losetup /dev/loop0 /tmp/mdtest0

For /dev/loop[0123]

Then I ran

     mdadm -CR /dev/md0 -e0.90 -l0 -n4 /dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3
     mdadm: 0.90 metadata does not support layouts for RAID0

My question is whether the regression tests in the tarball are valid for mdadm-4.2?

     -- Bruce Dubbs
        linuxfromscratch.org

Note: The kernel is version 5.15.12.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mdadm regression tests fail
       [not found] <c4c17b11-16f4-ef70-5897-02f923907963@gmail.com>
  2022-01-05  3:07 ` mdadm regression tests fail Bruce Dubbs
@ 2022-01-05 17:12 ` Randy Dunlap
  2022-01-05 17:44   ` Wols Lists
  1 sibling, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2022-01-05 17:12 UTC (permalink / raw)
  To: Bruce Dubbs, Linux Kernel Mailing List, linux-raid
  Cc: Douglas R. Reno, Pierre Labastie

Hi.
[adding linux-raid mailing list]


On 1/4/22 10:55, Bruce Dubbs wrote:
> I am trying to document the mdadm-4.2 installation procedures for our book,
> https://www.linuxfromscratch.org/blfs/view/svn/postlfs/mdadm.html
> 
> For testing, I am doing a simple:
> 
>   make
>   sudo ./test --keep-going --logdir=test-logs --save-logs
> 
> But I get failures for about half the tests.
> 
> Digging in a bit I just ran:
> 
>  sudo ./test --tests=00raid0 --logdir=test-logs
> 
> This is the first test that fails.  With some hacking, it appears that the first portion of this test that fails is:
> 
>   mdadm -CR $md0 -e0.90 -l0 -n4 $dev0 $dev1 $dev2 $dev3
> 
> This resolves to
> 
>   mdadm -CR /dev/md0 -e0.90 -l0 -n4 /dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3
> 
> There is not a lot of error output in the test, so I manually ran:
> 
>   dd if=/dev/zero of=/tmp/mdtest0 count=20000 bs=1K
>   losetup /dev/loop0 /tmp/mdtest0
> 
> For /dev/loop[0123]
> 
> Then I ran
> 
>   mdadm -CR /dev/md0 -e0.90 -l0 -n4 /dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3
>   mdadm: 0.90 metadata does not support layouts for RAID0
> 
> My question is whether the regression tests in the tarball are valid for mdadm-4.2?
> 
>   -- Bruce Dubbs
>      linuxfromscratch.org
> 
> Note: The kernel is version 5.15.12.

-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mdadm regression tests fail
  2022-01-05 17:12 ` Randy Dunlap
@ 2022-01-05 17:44   ` Wols Lists
  2022-01-05 20:42     ` Bruce Dubbs
  0 siblings, 1 reply; 5+ messages in thread
From: Wols Lists @ 2022-01-05 17:44 UTC (permalink / raw)
  To: Randy Dunlap, Bruce Dubbs, Linux Kernel Mailing List, linux-raid
  Cc: Douglas R. Reno, Pierre Labastie

Bear in mind raid superblock v0.9 is deprecated as in "if it breaks it 
won't be fixed for you".

So I would skip this test, and if you're mentioning raid in the 
handbook, tell people they need to use one of the v1.x formats.

(NB - you can always point them at the linux raid wiki.)

Cheers,
Wol

On 05/01/2022 17:12, Randy Dunlap wrote:
> Hi.
> [adding linux-raid mailing list]
> 
> 
> On 1/4/22 10:55, Bruce Dubbs wrote:
>> I am trying to document the mdadm-4.2 installation procedures for our book,
>> https://www.linuxfromscratch.org/blfs/view/svn/postlfs/mdadm.html
>>
>> For testing, I am doing a simple:
>>
>>    make
>>    sudo ./test --keep-going --logdir=test-logs --save-logs
>>
>> But I get failures for about half the tests.
>>
>> Digging in a bit I just ran:
>>
>>   sudo ./test --tests=00raid0 --logdir=test-logs
>>
>> This is the first test that fails.  With some hacking, it appears that the first portion of this test that fails is:
>>
>>    mdadm -CR $md0 -e0.90 -l0 -n4 $dev0 $dev1 $dev2 $dev3
>>
>> This resolves to
>>
>>    mdadm -CR /dev/md0 -e0.90 -l0 -n4 /dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3
>>
>> There is not a lot of error output in the test, so I manually ran:
>>
>>    dd if=/dev/zero of=/tmp/mdtest0 count=20000 bs=1K
>>    losetup /dev/loop0 /tmp/mdtest0
>>
>> For /dev/loop[0123]
>>
>> Then I ran
>>
>>    mdadm -CR /dev/md0 -e0.90 -l0 -n4 /dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3
>>    mdadm: 0.90 metadata does not support layouts for RAID0
>>
>> My question is whether the regression tests in the tarball are valid for mdadm-4.2?
>>
>>    -- Bruce Dubbs
>>       linuxfromscratch.org
>>
>> Note: The kernel is version 5.15.12.
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mdadm regression tests fail
  2022-01-05 17:44   ` Wols Lists
@ 2022-01-05 20:42     ` Bruce Dubbs
  2022-01-11 12:06       ` Mariusz Tkaczyk
  0 siblings, 1 reply; 5+ messages in thread
From: Bruce Dubbs @ 2022-01-05 20:42 UTC (permalink / raw)
  To: Wols Lists, Randy Dunlap, linux-raid; +Cc: Douglas R. Reno, Pierre Labastie

My point is that many of the tests fail.  It's not that someone should use the 
superblock v0.9.  That's only an example. The test should be removed or marked 
"Expected FAIL" or similar.  Our users run the tests as a confidence check that the 
build is successful.  They are generally not trying to debug the package.

I can certainly say that the tests are broken and leave it at that.  If it were only 
a couple of tests that fail, we generally say something like testA and testG are 
known to fail, but in this case fully half of the tests fail.

I would like to know what the maintainers think of the regression tests.  Are they 
maintained?  Should they all pass?  For our users there are far too many tests to run 
them individually.

   -- Bruce


On 1/5/22 11:44 AM, Wols Lists wrote:
> Bear in mind raid superblock v0.9 is deprecated as in "if it breaks it won't be fixed 
> for you".
> 
> So I would skip this test, and if you're mentioning raid in the handbook, tell people 
> they need to use one of the v1.x formats.
> 
> (NB - you can always point them at the linux raid wiki.)
> 
> Cheers,
> Wol
> 
> On 05/01/2022 17:12, Randy Dunlap wrote:
>> Hi.
>> [adding linux-raid mailing list]
>>
>>
>> On 1/4/22 10:55, Bruce Dubbs wrote:
>>> I am trying to document the mdadm-4.2 installation procedures for our book,
>>> https://www.linuxfromscratch.org/blfs/view/svn/postlfs/mdadm.html
>>>
>>> For testing, I am doing a simple:
>>>
>>>    make
>>>    sudo ./test --keep-going --logdir=test-logs --save-logs
>>>
>>> But I get failures for about half the tests.
>>>
>>> Digging in a bit I just ran:
>>>
>>>   sudo ./test --tests=00raid0 --logdir=test-logs
>>>
>>> This is the first test that fails.  With some hacking, it appears that the first 
>>> portion of this test that fails is:
>>>
>>>    mdadm -CR $md0 -e0.90 -l0 -n4 $dev0 $dev1 $dev2 $dev3
>>>
>>> This resolves to
>>>
>>>    mdadm -CR /dev/md0 -e0.90 -l0 -n4 /dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3
>>>
>>> There is not a lot of error output in the test, so I manually ran:
>>>
>>>    dd if=/dev/zero of=/tmp/mdtest0 count=20000 bs=1K
>>>    losetup /dev/loop0 /tmp/mdtest0
>>>
>>> For /dev/loop[0123]
>>>
>>> Then I ran
>>>
>>>    mdadm -CR /dev/md0 -e0.90 -l0 -n4 /dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3
>>>    mdadm: 0.90 metadata does not support layouts for RAID0
>>>
>>> My question is whether the regression tests in the tarball are valid for mdadm-4.2?
>>>
>>>    -- Bruce Dubbs
>>>       linuxfromscratch.org
>>>
>>> Note: The kernel is version 5.15.12.
>>
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mdadm regression tests fail
  2022-01-05 20:42     ` Bruce Dubbs
@ 2022-01-11 12:06       ` Mariusz Tkaczyk
  0 siblings, 0 replies; 5+ messages in thread
From: Mariusz Tkaczyk @ 2022-01-11 12:06 UTC (permalink / raw)
  To: Bruce Dubbs
  Cc: Wols Lists, Randy Dunlap, linux-raid, Douglas R. Reno,
	Pierre Labastie

On Wed, 5 Jan 2022 14:42:31 -0600
Bruce Dubbs <bruce.dubbs@gmail.com> wrote:

> My point is that many of the tests fail.  It's not that someone
> should use the superblock v0.9.  That's only an example. The test
> should be removed or marked "Expected FAIL" or similar.  Our users
> run the tests as a confidence check that the build is successful.
> They are generally not trying to debug the package.
> 
> I can certainly say that the tests are broken and leave it at that.
> If it were only a couple of tests that fail, we generally say
> something like testA and testG are known to fail, but in this case
> fully half of the tests fail.
> 
> I would like to know what the maintainers think of the regression
> tests.  Are they maintained?  Should they all pass?  For our users
> there are far too many tests to run them individually.
> 
>    -- Bruce
> 

Hi Bruce,
I can say that at least IMSM test are maintained and used regularly.
You can use this subgroup. I can also see some test
improvements submitted last time in mdadm repository, so I can assume
that there are some usages outside IMSM (at least for 1.x metadata).

Without continuous integration testing in upstream it is externally hard
to have all tests in good shape. The verification is done by users, as
you can see it is not used frequently. I'm closer to say that this part
in not maintained. You can take a challenge and fix them :)

Thanks,
Mariusz

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-01-11 12:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <c4c17b11-16f4-ef70-5897-02f923907963@gmail.com>
2022-01-05  3:07 ` mdadm regression tests fail Bruce Dubbs
2022-01-05 17:12 ` Randy Dunlap
2022-01-05 17:44   ` Wols Lists
2022-01-05 20:42     ` Bruce Dubbs
2022-01-11 12:06       ` Mariusz Tkaczyk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).