From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Jes Sorensen <jes@trained-monkey.org>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] udev: adapt rules to systemd v247
Date: Thu, 20 Jan 2022 08:58:20 +0100 [thread overview]
Message-ID: <20220120085820.0000704a@linux.intel.com> (raw)
In-Reply-To: <2263d913-f062-9ae0-9830-7c628e5eaeb7@trained-monkey.org>
On Wed, 19 Jan 2022 08:22:14 -0500
Jes Sorensen <jes@trained-monkey.org> wrote:
> On 1/14/22 10:44, Mariusz Tkaczyk wrote:
> > New events have been added in kernel 4.14 ("bind" and "unbind").
> > Systemd maintainer suggests to modify "add|change" branches.
> > This patches implements their suggestions. There is no issue yet
> > because new event types are not used in md.
> >
> > Please see systemd announcement for details[1].
> >
> > [1]
> > https://lists.freedesktop.org/archives/systemd-devel/2020-November/045646.html
> >
> > Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
>
> Hi Mariusz,
>
> It looks fine to me, but it does raise the question how does this
> change affect anyone building mdadm running an older systemd since
> you're removing most of the add|change triggers in this patch?
>
Hi Jes,
Before 4.14 we had tree types of events:
add, change, remove
After 4.14 we have five types of events:
add, change, remove, bind, unbind
I just changed "add|change" to != "remove". Instead verifying positive
cases, I excluded the negative one. The result is the same. I can't see
any risk of regression here for older systemd.
Thanks,
Mariusz
next prev parent reply other threads:[~2022-01-20 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 15:44 [PATCH] udev: adapt rules to systemd v247 Mariusz Tkaczyk
2022-01-19 13:22 ` Jes Sorensen
2022-01-20 7:58 ` Mariusz Tkaczyk [this message]
2022-03-22 15:32 ` Mariusz Tkaczyk
2022-03-31 15:41 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120085820.0000704a@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).