From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Song Liu <song@kernel.org>, "Theodore Ts'o" <tytso@mit.edu>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: [PATCH 03/10] pktcdvd: remove a pointless debug check in pkt_submit_bio
Date: Fri, 4 Mar 2022 19:00:58 +0100 [thread overview]
Message-ID: <20220304180105.409765-4-hch@lst.de> (raw)
In-Reply-To: <20220304180105.409765-1-hch@lst.de>
->queuedata is set up in pkt_init_queue, so it can't be NULL here.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/pktcdvd.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 623df4141ff3f..a52bbedd2f33d 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -2400,18 +2400,11 @@ static void pkt_make_request_write(struct request_queue *q, struct bio *bio)
static void pkt_submit_bio(struct bio *bio)
{
- struct pktcdvd_device *pd;
- char b[BDEVNAME_SIZE];
+ struct pktcdvd_device *pd = bio->bi_bdev->bd_disk->queue->queuedata;
struct bio *split;
blk_queue_split(&bio);
- pd = bio->bi_bdev->bd_disk->queue->queuedata;
- if (!pd) {
- pr_err("%s incorrect request queue\n", bio_devname(bio, b));
- goto end_io;
- }
-
pkt_dbg(2, pd, "start = %6llx stop = %6llx\n",
(unsigned long long)bio->bi_iter.bi_sector,
(unsigned long long)bio_end_sector(bio));
--
2.30.2
next prev parent reply other threads:[~2022-03-04 18:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 18:00 remove bio_devname Christoph Hellwig
2022-03-04 18:00 ` [PATCH 01/10] block: fix and cleanup bio_check_ro Christoph Hellwig
2022-03-07 3:05 ` Chaitanya Kulkarni
2022-03-04 18:00 ` [PATCH 02/10] block: remove handle_bad_sector Christoph Hellwig
2022-03-07 3:05 ` Chaitanya Kulkarni
2022-03-04 18:00 ` Christoph Hellwig [this message]
2022-03-04 18:00 ` [PATCH 04/10] dm-crypt: stop using bio_devname Christoph Hellwig
2022-03-07 3:07 ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 05/10] dm-integrity: " Christoph Hellwig
2022-03-07 3:07 ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 06/10] md-multipath: " Christoph Hellwig
2022-03-04 19:14 ` Song Liu
2022-03-07 3:07 ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 07/10] raid1: " Christoph Hellwig
2022-03-04 19:14 ` Song Liu
2022-03-07 3:06 ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 08/10] raid5-ppl: " Christoph Hellwig
2022-03-04 19:14 ` Song Liu
2022-03-04 18:01 ` [PATCH 09/10] ext4: " Christoph Hellwig
2022-03-07 3:08 ` Chaitanya Kulkarni
2022-03-04 18:01 ` [PATCH 10/10] block: remove bio_devname Christoph Hellwig
2022-03-07 3:06 ` Chaitanya Kulkarni
2022-03-07 11:38 ` Johannes Thumshirn
2022-03-07 13:42 ` Jens Axboe
2022-03-07 16:45 ` Mike Snitzer
2022-03-07 16:48 ` Christoph Hellwig
2022-03-07 16:56 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304180105.409765-4-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).