From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Wu Guanghao <wuguanghao3@huawei.com>
Cc: <jes@trained-monkey.org>, <linux-raid@vger.kernel.org>,
<linfeilong@huawei.com>, <lixiaokeng@huawei.com>
Subject: Re: [PATCH 1/5] parse_layout_faulty: fix memleak
Date: Tue, 31 May 2022 09:36:20 +0200 [thread overview]
Message-ID: <20220531093620.000058b4@linux.intel.com> (raw)
In-Reply-To: <bd8d7da6-83e7-da9b-1647-d95220a535e7@huawei.com>
On Tue, 31 May 2022 14:49:17 +0800
Wu Guanghao <wuguanghao3@huawei.com> wrote:
> char *m is allocated by xstrdup but not free() before return, will cause
> a memory leak
>
> Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
> ---
> util.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util.c b/util.c
> index cc94f96e..da18a68d 100644
> --- a/util.c
> +++ b/util.c
> @@ -429,6 +429,7 @@ int parse_layout_faulty(char *layout)
> int mode;
> m[ln] = 0;
> mode = map_name(faultylayout, m);
> + free(m);
> if (mode == UnSet)
> return -1;
>
Hi,
Please add empty lines to separate declarations and not related code
sections.
Thanks,
Mariusz
next prev parent reply other threads:[~2022-05-31 7:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 6:48 [PATCH 0/5] mdadm: fix memory leak and double free Wu Guanghao
2022-05-31 6:49 ` [PATCH 1/5] parse_layout_faulty: fix memleak Wu Guanghao
2022-05-31 7:36 ` Mariusz Tkaczyk [this message]
2022-06-07 7:24 ` Wu Guanghao
2022-05-31 6:49 ` [PATCH 2/5] Detail: " Wu Guanghao
2022-05-31 7:42 ` Mariusz Tkaczyk
2022-05-31 6:50 ` [PATCH 3/5] load_imsm_mpb: fix double free Wu Guanghao
2022-05-31 7:54 ` Mariusz Tkaczyk
2022-05-31 6:50 ` [PATCH 4/5] find_disk_attached_hba: fix memleak Wu Guanghao
2022-05-31 8:04 ` Mariusz Tkaczyk
2022-06-07 7:36 ` Wu Guanghao
2022-05-31 6:51 ` [PATCH 5/5] get_vd_num_of_subarray: " Wu Guanghao
2022-05-31 8:11 ` Mariusz Tkaczyk
2022-05-31 8:25 ` Paul Menzel
2022-06-07 6:32 ` Mariusz Tkaczyk
2022-05-31 6:57 ` [PATCH 0/5] mdadm: fix memory leak and double free Paul Menzel
2022-06-07 7:39 ` Wu Guanghao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531093620.000058b4@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linfeilong@huawei.com \
--cc=linux-raid@vger.kernel.org \
--cc=lixiaokeng@huawei.com \
--cc=wuguanghao3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).