From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2822CC43334 for ; Tue, 7 Jun 2022 18:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353790AbiFGSwB (ORCPT ); Tue, 7 Jun 2022 14:52:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354566AbiFGSrJ (ORCPT ); Tue, 7 Jun 2022 14:47:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 993E8106A49; Tue, 7 Jun 2022 11:02:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2FCB5618DF; Tue, 7 Jun 2022 18:02:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B48E4C341C0; Tue, 7 Jun 2022 18:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624934; bh=Ey7iL6fosCEa4G3JVohECvd448Bu8evLxnW3b+5ur4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NNS3vnVfLf40MGMZts+ZaljRUMiOqcDkYVZ4eB87MjmI22rJZU+O2kmTOKPOXQl2M Lys6vs+8RYUUwUp2XsbntbY3WhkLHdluehv+rmU0ga0zdZLapQaz68YkfuTUfyetp4 QNZ4PEwcrrLoWQfRLdXwoglcz8RSO5gZC5SU33mjw6NCYDpgaHt4+GvU5mMAtt2FDb UFWpfm+ZgnhWjbf/aF2TDonyyBItgFQqnoPt+eV1mptAEU1RAdZkOYIV1ldYFxZlIf Gur7eC8W9MSqJwzEAGiczI1HSMv7K/NLUCX//3WYW3ZY1iBuY7Z3zxHx3u0GZK8c35 5LskWk+ZowRDg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Guoqing Jiang , Donald Buczek , Guoqing Jiang , Song Liu , Sasha Levin , linux-raid@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 19/27] md: protect md_unregister_thread from reentrancy Date: Tue, 7 Jun 2022 14:01:23 -0400 Message-Id: <20220607180133.481701-19-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607180133.481701-1-sashal@kernel.org> References: <20220607180133.481701-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org From: Guoqing Jiang [ Upstream commit 1e267742283a4b5a8ca65755c44166be27e9aa0f ] Generally, the md_unregister_thread is called with reconfig_mutex, but raid_message in dm-raid doesn't hold reconfig_mutex to unregister thread, so md_unregister_thread can be called simulitaneously from two call sites in theory. Then after previous commit which remove the protection of reconfig_mutex for md_unregister_thread completely, the potential issue could be worse than before. Let's take pers_lock at the beginning of function to ensure reentrancy. Reported-by: Donald Buczek Signed-off-by: Guoqing Jiang Signed-off-by: Song Liu Signed-off-by: Sasha Levin --- drivers/md/md.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index da7954eff4d7..5439b6a71776 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -7618,17 +7618,22 @@ EXPORT_SYMBOL(md_register_thread); void md_unregister_thread(struct md_thread **threadp) { - struct md_thread *thread = *threadp; - if (!thread) - return; - pr_debug("interrupting MD-thread pid %d\n", task_pid_nr(thread->tsk)); - /* Locking ensures that mddev_unlock does not wake_up a + struct md_thread *thread; + + /* + * Locking ensures that mddev_unlock does not wake_up a * non-existent thread */ spin_lock(&pers_lock); + thread = *threadp; + if (!thread) { + spin_unlock(&pers_lock); + return; + } *threadp = NULL; spin_unlock(&pers_lock); + pr_debug("interrupting MD-thread pid %d\n", task_pid_nr(thread->tsk)); kthread_stop(thread->tsk); kfree(thread); } -- 2.35.1