From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Song Liu <song@kernel.org>,
Logan Gunthorpe <logang@deltatee.com>,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 08/10] md: stop using for_each_mddev in md_exit
Date: Tue, 19 Jul 2022 09:03:06 +0200 [thread overview]
Message-ID: <20220719070306.GA28422@lst.de> (raw)
In-Reply-To: <61d08fa6-91e4-f809-1074-d1ba2b1a3758@suse.de>
On Mon, Jul 18, 2022 at 09:10:59AM +0200, Hannes Reinecke wrote:
>
> Having thought about it some more ... wouldn't it make sense to modify
> mddev_get() to
>
> if (atomic_inc_not_zero(&mddev->active))
> return NULL;
>
> to ensure we're not missing any use-after-free issues, which previously
> would have been caught by the 'for_each_mddev()' macro?
No. mddev->active = 0 can still be a perfectly valid mddev and they
are not automatically deleted. Check the conditions in mddev_put.
next prev parent reply other threads:[~2022-07-19 7:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 6:34 fix md disk_name lifetime problems v3 Christoph Hellwig
2022-07-18 6:34 ` [PATCH 01/10] md: fix mddev->kobj lifetime Christoph Hellwig
2022-07-18 6:55 ` Hannes Reinecke
2022-07-18 19:48 ` Logan Gunthorpe
2022-07-18 6:34 ` [PATCH 02/10] md: fix error handling in md_alloc Christoph Hellwig
2022-07-18 7:00 ` Hannes Reinecke
2022-07-18 19:48 ` Logan Gunthorpe
2022-07-18 6:34 ` [PATCH 03/10] md: implement ->free_disk Christoph Hellwig
2022-07-18 7:01 ` Hannes Reinecke
2022-07-18 20:01 ` Logan Gunthorpe
2022-07-18 6:34 ` [PATCH 04/10] md: rename md_free to md_kobj_release Christoph Hellwig
2022-07-18 7:01 ` Hannes Reinecke
2022-07-18 20:02 ` Logan Gunthorpe
2022-07-18 6:34 ` [PATCH 05/10] md: factor out the rdev overlaps check from rdev_size_store Christoph Hellwig
2022-07-18 7:02 ` Hannes Reinecke
2022-07-18 20:02 ` Logan Gunthorpe
2022-07-18 6:34 ` [PATCH 06/10] md: stop using for_each_mddev in md_do_sync Christoph Hellwig
2022-07-18 7:03 ` Hannes Reinecke
2022-07-18 20:02 ` Logan Gunthorpe
2022-07-18 6:34 ` [PATCH 07/10] md: stop using for_each_mddev in md_notify_reboot Christoph Hellwig
2022-07-18 7:05 ` Hannes Reinecke
2022-07-18 20:03 ` Logan Gunthorpe
2022-07-18 6:34 ` [PATCH 08/10] md: stop using for_each_mddev in md_exit Christoph Hellwig
2022-07-18 7:10 ` Hannes Reinecke
2022-07-19 7:03 ` Christoph Hellwig [this message]
2022-07-19 7:06 ` Hannes Reinecke
2022-07-18 20:03 ` Logan Gunthorpe
2022-07-18 6:34 ` [PATCH 09/10] md: only delete entries from all_mddevs when the disk is freed Christoph Hellwig
2022-07-18 7:17 ` Hannes Reinecke
2022-07-18 18:20 ` Song Liu
2022-07-19 5:06 ` Christoph Hellwig
2022-07-19 6:28 ` Song Liu
2022-07-19 7:00 ` Hannes Reinecke
2022-07-19 7:14 ` Christoph Hellwig
2022-07-19 7:59 ` Hannes Reinecke
2022-07-18 6:34 ` [PATCH 10/10] md: simplify md_open Christoph Hellwig
2022-07-18 7:19 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2022-07-19 9:18 fix md disk_name lifetime problems v4 Christoph Hellwig
2022-07-19 9:18 ` [PATCH 08/10] md: stop using for_each_mddev in md_exit Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719070306.GA28422@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).