linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michal Koutný" <mkoutny@suse.com>
To: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>,
	systemd-devel@lists.freedesktop.org
Cc: NeilBrown <neilb@suse.de>, Coly Li <colyli@suse.de>,
	linux-raid@vger.kernel.org, Benjamin Brunner <bbrunner@suse.com>,
	Franck Bui <fbui@suse.de>, Jes Sorensen <jes@trained-monkey.org>,
	Xiao Ni <xni@redhat.com>
Subject: Re: [PATCH] mdadm/systemd: remove KillMode=none from service file
Date: Mon, 29 Aug 2022 18:19:28 +0200	[thread overview]
Message-ID: <20220829161928.GA4273@blackbody.suse.cz> (raw)
In-Reply-To: <20220818140707.00007b43@linux.intel.com> <20220824145756.000048f8@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

Hello.

On Wed, Aug 24, 2022 at 02:57:56PM +0200, Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:
> It will be great if you can really prove that the mechanism is working. Do you
> know any project which really uses this functionality?

My knee-jerk response would be open-iscsi daemon but I know that this
one in particular works without '@', so I can't answer your query.

(But generally, it would only protect against the "global" killing upon
initrd transitions, not the killing of a single unit. That's likely what
you run into first during shutdown.)

Let me cross-post (back [1]) to systemd-devel ML.

> We need to handle dirty clean transaction. On shutdown, when umount is
> requested them filesystem could flush in flight data, and them kernel is
> waiting for mdmon to acknowledge the change in metadata[2].

So, technically, you'd want to order the mdmon service wrt .mount unit.
But that's unfortunately not known when mdmon@ starts based on a udev rule.

Therefore, I suspect removal of KillMode=none would need some version
of [2] to accomodate such device-service orderings.

Michal


[1] In-Reply-To: https://lists.freedesktop.org/archives/systemd-devel/2022-August/048201.html
[1] In-Reply-To: https://lore.kernel.org/r/20220824145756.000048f8@linux.intel.com/
[2] https://github.com/Werkov/systemd/commit/bdaa49d34e78981f3535c42ec19ac0f314135c07

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2022-08-29 16:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 13:34 [PATCH] mdadm/systemd: remove KillMode=none from service file Coly Li
2022-04-06  6:36 ` Xiao Ni
2022-04-06 13:35   ` Jes Sorensen
2022-07-28  7:55 ` Mariusz Tkaczyk
2022-07-28  8:39   ` Coly Li
2022-07-28  9:01     ` Mariusz Tkaczyk
2022-07-28 10:55       ` Coly Li
2022-07-29  7:55         ` Mariusz Tkaczyk
2022-07-29  1:55   ` NeilBrown
2022-08-02 15:43     ` Mariusz Tkaczyk
2022-08-18 22:00       ` Michal Koutný
2022-08-24  9:52         ` Mariusz Tkaczyk
2022-08-24 12:03           ` Michal Koutný
2022-08-24 12:57             ` Mariusz Tkaczyk
2022-08-29 16:19               ` Michal Koutný [this message]
2022-10-04 10:24   ` Mariusz Tkaczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220829161928.GA4273@blackbody.suse.cz \
    --to=mkoutny@suse.com \
    --cc=bbrunner@suse.com \
    --cc=colyli@suse.de \
    --cc=fbui@suse.de \
    --cc=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=neilb@suse.de \
    --cc=systemd-devel@lists.freedesktop.org \
    --cc=xni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).