From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6FCC38145 for ; Wed, 7 Sep 2022 07:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbiIGHdz (ORCPT ); Wed, 7 Sep 2022 03:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbiIGHdq (ORCPT ); Wed, 7 Sep 2022 03:33:46 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 426B4A4051; Wed, 7 Sep 2022 00:33:29 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id EE9656732D; Wed, 7 Sep 2022 09:33:24 +0200 (CEST) Date: Wed, 7 Sep 2022 09:33:24 +0200 From: Christoph Hellwig To: Ming Lei Cc: Dusty Mabe , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, linux-raid@vger.kernel.org Subject: Re: regression caused by block: freeze the queue earlier in del_gendisk Message-ID: <20220907073324.GB23826@lst.de> References: <017845ae-fbae-70f6-5f9e-29aff2742b8c@dustymabe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Thu, Sep 01, 2022 at 03:06:08PM +0800, Ming Lei wrote: > It is a bit hard to associate the above commit with reported issue. So the messages clearly are about something trying to open a device that went away at the block layer, but somehow does not get removed in time by udev (which seems to be a userspace bug in CoreOS). But even with that we really should not hang. Now that fact that it did hang before and this now becomes reproducible also makes me assume the change is not the root cause. It might still be a good vehicle to fix the issue for real, but it really broadens the scope.