* [PATCH v2 0/2] Small fixes from Debian
@ 2022-09-09 13:50 Mariusz Tkaczyk
2022-09-09 13:50 ` [PATCH v2 1/2] mdadm: Add Documentation entries to systemd services Mariusz Tkaczyk
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mariusz Tkaczyk @ 2022-09-09 13:50 UTC (permalink / raw)
To: jes, colyli; +Cc: felix.lechner, linux-raid
Hi Jes and Coly,
Here we have small Debian customizations worth to be integrated.
Changes:
- Commit title updated, suggested by Paul.
Mariusz Tkaczyk (2):
mdadm: Add Documentation entries to systemd services
ReadMe: fix command-line help
ReadMe.c | 2 +-
systemd/mdadm-grow-continue@.service | 1 +
systemd/mdadm-last-resort@.service | 1 +
systemd/mdcheck_continue.service | 3 ++-
systemd/mdcheck_start.service | 1 +
systemd/mdmon@.service | 1 +
systemd/mdmonitor-oneshot.service | 1 +
systemd/mdmonitor.service | 1 +
8 files changed, 9 insertions(+), 2 deletions(-)
--
2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2 1/2] mdadm: Add Documentation entries to systemd services 2022-09-09 13:50 [PATCH v2 0/2] Small fixes from Debian Mariusz Tkaczyk @ 2022-09-09 13:50 ` Mariusz Tkaczyk 2022-09-16 15:03 ` Coly Li 2022-09-09 13:50 ` [PATCH v2 2/2] ReadMe: fix command-line help Mariusz Tkaczyk 2022-09-16 19:27 ` [PATCH v2 0/2] Small fixes from Debian Jes Sorensen 2 siblings, 1 reply; 6+ messages in thread From: Mariusz Tkaczyk @ 2022-09-09 13:50 UTC (permalink / raw) To: jes, colyli; +Cc: felix.lechner, linux-raid Add documentation section. Copied from Debian. Cc: Felix Lechner <felix.lechner@lease-up.com> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> --- systemd/mdadm-grow-continue@.service | 1 + systemd/mdadm-last-resort@.service | 1 + systemd/mdcheck_continue.service | 3 ++- systemd/mdcheck_start.service | 1 + systemd/mdmon@.service | 1 + systemd/mdmonitor-oneshot.service | 1 + systemd/mdmonitor.service | 1 + 7 files changed, 8 insertions(+), 1 deletion(-) diff --git a/systemd/mdadm-grow-continue@.service b/systemd/mdadm-grow-continue@.service index 9fdc8ec..64b8254 100644 --- a/systemd/mdadm-grow-continue@.service +++ b/systemd/mdadm-grow-continue@.service @@ -8,6 +8,7 @@ [Unit] Description=Manage MD Reshape on /dev/%I DefaultDependencies=no +Documentation=man:mdadm(8) [Service] ExecStart=BINDIR/mdadm --grow --continue /dev/%I diff --git a/systemd/mdadm-last-resort@.service b/systemd/mdadm-last-resort@.service index efeb3f6..e938112 100644 --- a/systemd/mdadm-last-resort@.service +++ b/systemd/mdadm-last-resort@.service @@ -2,6 +2,7 @@ Description=Activate md array %I even though degraded DefaultDependencies=no ConditionPathExists=!/sys/devices/virtual/block/%i/md/sync_action +Documentation=man:mdadm(8) [Service] Type=oneshot diff --git a/systemd/mdcheck_continue.service b/systemd/mdcheck_continue.service index 854317f..f532490 100644 --- a/systemd/mdcheck_continue.service +++ b/systemd/mdcheck_continue.service @@ -7,7 +7,8 @@ [Unit] Description=MD array scrubbing - continuation -ConditionPathExistsGlob = /var/lib/mdcheck/MD_UUID_* +ConditionPathExistsGlob=/var/lib/mdcheck/MD_UUID_* +Documentation=man:mdadm(8) [Service] Type=oneshot diff --git a/systemd/mdcheck_start.service b/systemd/mdcheck_start.service index 3bb3d13..703a658 100644 --- a/systemd/mdcheck_start.service +++ b/systemd/mdcheck_start.service @@ -8,6 +8,7 @@ [Unit] Description=MD array scrubbing Wants=mdcheck_continue.timer +Documentation=man:mdadm(8) [Service] Type=oneshot diff --git a/systemd/mdmon@.service b/systemd/mdmon@.service index 7753395..97a1acd 100644 --- a/systemd/mdmon@.service +++ b/systemd/mdmon@.service @@ -9,6 +9,7 @@ Description=MD Metadata Monitor on /dev/%I DefaultDependencies=no Before=initrd-switch-root.target +Documentation=man:mdmon(8) [Service] # mdmon should never complain due to lack of a platform, diff --git a/systemd/mdmonitor-oneshot.service b/systemd/mdmonitor-oneshot.service index 373955a..ba86b44 100644 --- a/systemd/mdmonitor-oneshot.service +++ b/systemd/mdmonitor-oneshot.service @@ -7,6 +7,7 @@ [Unit] Description=Reminder for degraded MD arrays +Documentation=man:mdadm(8) [Service] Environment=MDADM_MONITOR_ARGS=--scan diff --git a/systemd/mdmonitor.service b/systemd/mdmonitor.service index 46f7b88..9c36478 100644 --- a/systemd/mdmonitor.service +++ b/systemd/mdmonitor.service @@ -8,6 +8,7 @@ [Unit] Description=MD array monitor DefaultDependencies=no +Documentation=man:mdadm(8) [Service] Environment= MDADM_MONITOR_ARGS=--scan -- 2.26.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] mdadm: Add Documentation entries to systemd services 2022-09-09 13:50 ` [PATCH v2 1/2] mdadm: Add Documentation entries to systemd services Mariusz Tkaczyk @ 2022-09-16 15:03 ` Coly Li 0 siblings, 0 replies; 6+ messages in thread From: Coly Li @ 2022-09-16 15:03 UTC (permalink / raw) To: Mariusz Tkaczyk; +Cc: Jes Sorensen, felix.lechner, linux-raid > 2022年9月9日 21:50，Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> 写道： > > Add documentation section. > Copied from Debian. > > Cc: Felix Lechner <felix.lechner@lease-up.com> > Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> Acked-by: Coly Li <colyli@suse.de> Thanks. Coly Li > --- > systemd/mdadm-grow-continue@.service | 1 + > systemd/mdadm-last-resort@.service | 1 + > systemd/mdcheck_continue.service | 3 ++- > systemd/mdcheck_start.service | 1 + > systemd/mdmon@.service | 1 + > systemd/mdmonitor-oneshot.service | 1 + > systemd/mdmonitor.service | 1 + > 7 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/systemd/mdadm-grow-continue@.service b/systemd/mdadm-grow-continue@.service > index 9fdc8ec..64b8254 100644 > --- a/systemd/mdadm-grow-continue@.service > +++ b/systemd/mdadm-grow-continue@.service > @@ -8,6 +8,7 @@ > [Unit] > Description=Manage MD Reshape on /dev/%I > DefaultDependencies=no > +Documentation=man:mdadm(8) > > [Service] > ExecStart=BINDIR/mdadm --grow --continue /dev/%I > diff --git a/systemd/mdadm-last-resort@.service b/systemd/mdadm-last-resort@.service > index efeb3f6..e938112 100644 > --- a/systemd/mdadm-last-resort@.service > +++ b/systemd/mdadm-last-resort@.service > @@ -2,6 +2,7 @@ > Description=Activate md array %I even though degraded > DefaultDependencies=no > ConditionPathExists=!/sys/devices/virtual/block/%i/md/sync_action > +Documentation=man:mdadm(8) > > [Service] > Type=oneshot > diff --git a/systemd/mdcheck_continue.service b/systemd/mdcheck_continue.service > index 854317f..f532490 100644 > --- a/systemd/mdcheck_continue.service > +++ b/systemd/mdcheck_continue.service > @@ -7,7 +7,8 @@ > > [Unit] > Description=MD array scrubbing - continuation > -ConditionPathExistsGlob = /var/lib/mdcheck/MD_UUID_* > +ConditionPathExistsGlob=/var/lib/mdcheck/MD_UUID_* > +Documentation=man:mdadm(8) > > [Service] > Type=oneshot > diff --git a/systemd/mdcheck_start.service b/systemd/mdcheck_start.service > index 3bb3d13..703a658 100644 > --- a/systemd/mdcheck_start.service > +++ b/systemd/mdcheck_start.service > @@ -8,6 +8,7 @@ > [Unit] > Description=MD array scrubbing > Wants=mdcheck_continue.timer > +Documentation=man:mdadm(8) > > [Service] > Type=oneshot > diff --git a/systemd/mdmon@.service b/systemd/mdmon@.service > index 7753395..97a1acd 100644 > --- a/systemd/mdmon@.service > +++ b/systemd/mdmon@.service > @@ -9,6 +9,7 @@ > Description=MD Metadata Monitor on /dev/%I > DefaultDependencies=no > Before=initrd-switch-root.target > +Documentation=man:mdmon(8) > > [Service] > # mdmon should never complain due to lack of a platform, > diff --git a/systemd/mdmonitor-oneshot.service b/systemd/mdmonitor-oneshot.service > index 373955a..ba86b44 100644 > --- a/systemd/mdmonitor-oneshot.service > +++ b/systemd/mdmonitor-oneshot.service > @@ -7,6 +7,7 @@ > > [Unit] > Description=Reminder for degraded MD arrays > +Documentation=man:mdadm(8) > > [Service] > Environment=MDADM_MONITOR_ARGS=--scan > diff --git a/systemd/mdmonitor.service b/systemd/mdmonitor.service > index 46f7b88..9c36478 100644 > --- a/systemd/mdmonitor.service > +++ b/systemd/mdmonitor.service > @@ -8,6 +8,7 @@ > [Unit] > Description=MD array monitor > DefaultDependencies=no > +Documentation=man:mdadm(8) > > [Service] > Environment= MDADM_MONITOR_ARGS=--scan > -- > 2.26.2 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] ReadMe: fix command-line help 2022-09-09 13:50 [PATCH v2 0/2] Small fixes from Debian Mariusz Tkaczyk 2022-09-09 13:50 ` [PATCH v2 1/2] mdadm: Add Documentation entries to systemd services Mariusz Tkaczyk @ 2022-09-09 13:50 ` Mariusz Tkaczyk 2022-09-16 15:04 ` Coly Li 2022-09-16 19:27 ` [PATCH v2 0/2] Small fixes from Debian Jes Sorensen 2 siblings, 1 reply; 6+ messages in thread From: Mariusz Tkaczyk @ 2022-09-09 13:50 UTC (permalink / raw) To: jes, colyli; +Cc: felix.lechner, linux-raid Make command-line help consistent with manual page. Copied from Debian. Cc: Felix Lechner <felix.lechner@lease-up.com> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> --- ReadMe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReadMe.c b/ReadMe.c index 7f94847..50a5e36 100644 --- a/ReadMe.c +++ b/ReadMe.c @@ -477,7 +477,7 @@ char Help_assemble[] = ; char Help_manage[] = -"Usage: mdadm arraydevice options component devices...\n" +"Usage: mdadm [mode] arraydevice [options] <component devices...>\n" "\n" "This usage is for managing the component devices within an array.\n" "The --manage option is not needed and is assumed if the first argument\n" -- 2.26.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] ReadMe: fix command-line help 2022-09-09 13:50 ` [PATCH v2 2/2] ReadMe: fix command-line help Mariusz Tkaczyk @ 2022-09-16 15:04 ` Coly Li 0 siblings, 0 replies; 6+ messages in thread From: Coly Li @ 2022-09-16 15:04 UTC (permalink / raw) To: Mariusz Tkaczyk; +Cc: Jes Sorensen, felix.lechner, linux-raid > 2022年9月9日 21:50，Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> 写道： > > Make command-line help consistent with manual page. > Copied from Debian. > > Cc: Felix Lechner <felix.lechner@lease-up.com> > Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> Acked-by: Coly Li <colyli@suse.de> Thanks. Coly Li > --- > ReadMe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ReadMe.c b/ReadMe.c > index 7f94847..50a5e36 100644 > --- a/ReadMe.c > +++ b/ReadMe.c > @@ -477,7 +477,7 @@ char Help_assemble[] = > ; > > char Help_manage[] = > -"Usage: mdadm arraydevice options component devices...\n" > +"Usage: mdadm [mode] arraydevice [options] <component devices...>\n" > "\n" > "This usage is for managing the component devices within an array.\n" > "The --manage option is not needed and is assumed if the first argument\n" > -- > 2.26.2 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] Small fixes from Debian 2022-09-09 13:50 [PATCH v2 0/2] Small fixes from Debian Mariusz Tkaczyk 2022-09-09 13:50 ` [PATCH v2 1/2] mdadm: Add Documentation entries to systemd services Mariusz Tkaczyk 2022-09-09 13:50 ` [PATCH v2 2/2] ReadMe: fix command-line help Mariusz Tkaczyk @ 2022-09-16 19:27 ` Jes Sorensen 2 siblings, 0 replies; 6+ messages in thread From: Jes Sorensen @ 2022-09-16 19:27 UTC (permalink / raw) To: Mariusz Tkaczyk, colyli; +Cc: felix.lechner, linux-raid On 9/9/22 09:50, Mariusz Tkaczyk wrote: > Hi Jes and Coly, > Here we have small Debian customizations worth to be integrated. > > Changes: > - Commit title updated, suggested by Paul. > > Mariusz Tkaczyk (2): > mdadm: Add Documentation entries to systemd services > ReadMe: fix command-line help > > ReadMe.c | 2 +- > systemd/mdadm-grow-continue@.service | 1 + > systemd/mdadm-last-resort@.service | 1 + > systemd/mdcheck_continue.service | 3 ++- > systemd/mdcheck_start.service | 1 + > systemd/mdmon@.service | 1 + > systemd/mdmonitor-oneshot.service | 1 + > systemd/mdmonitor.service | 1 + > 8 files changed, 9 insertions(+), 2 deletions(-) > Applied! Thanks, Jes ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-16 19:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-09 13:50 [PATCH v2 0/2] Small fixes from Debian Mariusz Tkaczyk 2022-09-09 13:50 ` [PATCH v2 1/2] mdadm: Add Documentation entries to systemd services Mariusz Tkaczyk 2022-09-16 15:03 ` Coly Li 2022-09-09 13:50 ` [PATCH v2 2/2] ReadMe: fix command-line help Mariusz Tkaczyk 2022-09-16 15:04 ` Coly Li 2022-09-16 19:27 ` [PATCH v2 0/2] Small fixes from Debian Jes Sorensen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).