From: Jonathan Derrick <jonathan.derrick@linux.dev>
To: Song Liu <song@kernel.org>
Cc: <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
jonathan.derrick@solidigm.com, jonathanx.sk.derrick@intel.com,
Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>,
Jonathan Derrick <jonathan.derrick@linux.dev>
Subject: [PATCH v2 0/3] Bitmap percentage flushing
Date: Thu, 13 Oct 2022 16:41:48 -0600 [thread overview]
Message-ID: <20221013224151.300-1-jonathan.derrick@linux.dev> (raw)
This introduces a percentage-flushing mechanism that works in-tandem to the
mdadm delay timer. The percentage argument is based on the number of chunks
dirty (rather than percentage), due to large drives requiring smaller and
smaller percentages (eg, 32TB drives-> 1% is 320GB).
This set hopes to provide a way to make the bitmap flushing more consistent. It
was observed that a synchronous, random write qd1 workload, could make bitmap
writes easily become almost half of the I/O. And in similar workloads with
different timing, it was several minutes between bitmap updates. This is too
inconsistent to be reliable.
This first and second patches adds the flush_threshold parameter. The default
value of 0 defines the default behavior: unplugging immediately just as before.
With a flush-threshold value of 1, it becomes more consistent and paranoid,
flushing on nearly every I/O, leading to a 40% or greater situation. From
there, the flush_threshold can be defined higher for those situations where
power loss is rare and full resync can be tolerated.
The third patch converts the daemon worker to an actual timer. This makes it
more consistent and removes some ugly code.
Jonathan Derrick (3):
md/bitmap: Add chunk-threshold unplugging
md/bitmap: Add sysfs interface for flush threshold
md/bitmap: Convert daemon_work to proper timer
Documentation/admin-guide/md.rst | 5 ++
drivers/md/md-bitmap.c | 98 +++++++++++++++++++++++++-------
drivers/md/md-bitmap.h | 4 +-
drivers/md/md.c | 9 ++-
drivers/md/md.h | 2 +
5 files changed, 93 insertions(+), 25 deletions(-)
--
2.31.1
next reply other threads:[~2022-10-13 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 22:41 Jonathan Derrick [this message]
2022-10-13 22:41 ` [PATCH v2 1/3] md/bitmap: Add chunk-threshold unplugging Jonathan Derrick
2022-10-14 1:11 ` Jonathan Derrick
2022-10-13 22:41 ` [PATCH v2 2/3] md/bitmap: Add sysfs interface for flush threshold Jonathan Derrick
2022-10-13 22:41 ` [PATCH v2 3/3] md/bitmap: Convert daemon_work to proper timer Jonathan Derrick
2022-10-14 21:10 ` [PATCH v2 0/3] Bitmap percentage flushing John Stoffel
2022-10-15 22:27 ` Jonathan Derrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013224151.300-1-jonathan.derrick@linux.dev \
--to=jonathan.derrick@linux.dev \
--cc=jonathan.derrick@solidigm.com \
--cc=jonathanx.sk.derrick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).