From: Jonathan Derrick <jonathan.derrick@linux.dev>
To: Song Liu <song@kernel.org>
Cc: <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
jonathan.derrick@solidigm.com, jonathanx.sk.derrick@intel.com,
Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>,
Jonathan Derrick <jonathan.derrick@linux.dev>
Subject: [PATCH v2 2/3] md/bitmap: Add sysfs interface for flush threshold
Date: Thu, 13 Oct 2022 16:41:50 -0600 [thread overview]
Message-ID: <20221013224151.300-3-jonathan.derrick@linux.dev> (raw)
In-Reply-To: <20221013224151.300-1-jonathan.derrick@linux.dev>
Adds a sysfs interface in the bitmap device for setting the chunk flush
threshold. This is an unsigned integer value which defines the amount of
dirty chunks allowed to be pending between bitmap flushes.
Signed-off-by: Jonathan Derrick <jonathan.derrick@linux.dev>
---
Documentation/admin-guide/md.rst | 5 +++++
drivers/md/md-bitmap.c | 33 ++++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/Documentation/admin-guide/md.rst b/Documentation/admin-guide/md.rst
index d8fc9a59c086..d688ae4065cf 100644
--- a/Documentation/admin-guide/md.rst
+++ b/Documentation/admin-guide/md.rst
@@ -401,6 +401,11 @@ All md devices contain:
once the array becomes non-degraded, and this fact has been
recorded in the metadata.
+ bitmap/flush_threshold
+ The number of outstanding dirty chunks that are allowed to be pending
+ before unplugging the bitmap queue. The default behavior is to always
+ unplugging the queue when requested.
+
consistency_policy
This indicates how the array maintains consistency in case of unexpected
shutdown. It can be:
diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index c5c77f8371a8..cd8250368860 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -2652,6 +2652,38 @@ static struct md_sysfs_entry max_backlog_used =
__ATTR(max_backlog_used, S_IRUGO | S_IWUSR,
behind_writes_used_show, behind_writes_used_reset);
+static ssize_t
+bitmap_flush_threshold_show(struct mddev *mddev, char *page)
+{
+ ssize_t ret;
+ spin_lock(&mddev->lock);
+ if (mddev->bitmap == NULL)
+ ret = sprintf(page, "0\n");
+ else
+ ret = sprintf(page, "%u\n",
+ mddev->bitmap_info.flush_threshold);
+ spin_unlock(&mddev->lock);
+ return ret;
+}
+
+static ssize_t
+bitmap_flush_threshold_store(struct mddev *mddev, const char *buf, size_t len)
+{
+ unsigned int thresh;
+ int ret;
+ if (!mddev->bitmap)
+ return -ENOENT;
+ ret = kstrtouint(buf, 10, &thresh);
+ if (ret)
+ return ret;
+ mddev->bitmap_info.flush_threshold = thresh;
+ return len;
+}
+
+static struct md_sysfs_entry bitmap_flush_threshold =
+__ATTR(flush_threshold, S_IRUGO | S_IWUSR,
+ bitmap_flush_threshold_show, bitmap_flush_threshold_store);
+
static struct attribute *md_bitmap_attrs[] = {
&bitmap_location.attr,
&bitmap_space.attr,
@@ -2661,6 +2693,7 @@ static struct attribute *md_bitmap_attrs[] = {
&bitmap_metadata.attr,
&bitmap_can_clear.attr,
&max_backlog_used.attr,
+ &bitmap_flush_threshold.attr,
NULL
};
const struct attribute_group md_bitmap_group = {
--
2.31.1
next prev parent reply other threads:[~2022-10-13 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 22:41 [PATCH v2 0/3] Bitmap percentage flushing Jonathan Derrick
2022-10-13 22:41 ` [PATCH v2 1/3] md/bitmap: Add chunk-threshold unplugging Jonathan Derrick
2022-10-14 1:11 ` Jonathan Derrick
2022-10-13 22:41 ` Jonathan Derrick [this message]
2022-10-13 22:41 ` [PATCH v2 3/3] md/bitmap: Convert daemon_work to proper timer Jonathan Derrick
2022-10-14 21:10 ` [PATCH v2 0/3] Bitmap percentage flushing John Stoffel
2022-10-15 22:27 ` Jonathan Derrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013224151.300-3-jonathan.derrick@linux.dev \
--to=jonathan.derrick@linux.dev \
--cc=jonathan.derrick@solidigm.com \
--cc=jonathanx.sk.derrick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).