From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9460FC47090 for ; Tue, 6 Dec 2022 14:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235017AbiLFOu6 (ORCPT ); Tue, 6 Dec 2022 09:50:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235120AbiLFOuy (ORCPT ); Tue, 6 Dec 2022 09:50:54 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B7462EF26; Tue, 6 Dec 2022 06:49:11 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 7B3F668B05; Tue, 6 Dec 2022 15:49:02 +0100 (CET) Date: Tue, 6 Dec 2022 15:49:02 +0100 From: Christoph Hellwig To: Coly Li Cc: Christoph Hellwig , Jens Axboe , snitzer@kernel.org, Song Liu , linux-block@vger.kernel.org, linux-raid , linux-bcache@vger.kernel.org, dm-devel@redhat.com Subject: Re: [PATCH] block: remove bio_set_op_attrs Message-ID: <20221206144902.GA31845@lst.de> References: <20221206144057.720846-1-hch@lst.de> <434E4CE3-EA46-4CD9-9EAF-5C1B99B8A603@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <434E4CE3-EA46-4CD9-9EAF-5C1B99B8A603@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Tue, Dec 06, 2022 at 10:46:31PM +0800, Coly Li wrote: > BTW, may I ask why bio_set_op_attrs() is removed. Quite long time ago it was added to avoid open code, and now we remove it to use open coded assignments. What is the motivation for now? It was added when the flags encoding was a mess. Now that the RQF_ flags are split out things have become much simpler and we don't need to hide a simple assignment of a value to a field.