From: linan666@huaweicloud.com
To: song@kernel.org
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
linan122@huawei.com, yukuai3@huawei.com, yi.zhang@huawei.com,
houtao1@huawei.com, yangerkun@huawei.com
Subject: [PATCH 2/3] md: remove redundant check in fix_read_error()
Date: Sat, 24 Jun 2023 01:32:35 +0800 [thread overview]
Message-ID: <20230623173236.2513554-3-linan666@huaweicloud.com> (raw)
In-Reply-To: <20230623173236.2513554-1-linan666@huaweicloud.com>
From: Li Nan <linan122@huawei.com>
In fix_read_error(), 'success' will be checked immediately after assigning
it, if it is set to 1 then the loop will break. Checking it again in
condition of loop is redundant. Clean it up.
Signed-off-by: Li Nan <linan122@huawei.com>
---
drivers/md/raid1.c | 2 +-
drivers/md/raid10.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 3570da63969b..0391c2d0c109 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -2318,7 +2318,7 @@ static void fix_read_error(struct r1conf *conf, int read_disk,
d++;
if (d == conf->raid_disks * 2)
d = 0;
- } while (!success && d != read_disk);
+ } while (d != read_disk);
if (!success) {
/* Cannot read from anywhere - mark it bad */
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 94ae294c8a3c..a36e53fce21f 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2790,7 +2790,7 @@ static void fix_read_error(struct r10conf *conf, struct mddev *mddev, struct r10
sl++;
if (sl == conf->copies)
sl = 0;
- } while (!success && sl != slot);
+ } while (sl != slot);
rcu_read_unlock();
if (!success) {
--
2.39.2
next prev parent reply other threads:[~2023-06-23 9:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 17:32 [PATCH 0/3] md/raid10: optimize and fix read error linan666
2023-06-23 9:52 ` Paul Menzel
2023-06-25 1:23 ` Li Nan
2023-06-23 17:32 ` [PATCH 1/3] md/raid10: optimize fix_read_error linan666
2023-06-23 10:03 ` Paul Menzel
2023-06-25 6:44 ` Li Nan
2023-06-26 2:28 ` Yu Kuai
2023-06-23 17:32 ` linan666 [this message]
2023-06-26 2:31 ` [PATCH 2/3] md: remove redundant check in fix_read_error() Yu Kuai
2023-06-23 17:32 ` [PATCH 3/3] md/raid10: handle replacement devices in fix_read_error linan666
2023-06-26 2:42 ` Yu Kuai
2023-07-07 8:16 ` [PATCH 0/3] md/raid10: optimize and fix read error Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623173236.2513554-3-linan666@huaweicloud.com \
--to=linan666@huaweicloud.com \
--cc=houtao1@huawei.com \
--cc=linan122@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox