linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xueshi Hu <xueshi.hu@smartx.com>
To: song@kernel.org
Cc: linux-raid@vger.kernel.org, Xueshi Hu <xueshi.hu@smartx.com>
Subject: [PATCH v2 1/3] md/raid1: gave up reshape in case there's queued io
Date: Sun,  9 Jul 2023 18:29:54 +0800	[thread overview]
Message-ID: <20230709102956.1716708-2-hubachelar@gmail.com> (raw)
In-Reply-To: <20230709102956.1716708-1-hubachelar@gmail.com>

From: Xueshi Hu <xueshi.hu@smartx.com>

When an IO error happens, reschedule_retry() will increase
r1conf::nr_queued, which makes freeze_array() unblocked. However, before
all r1bio in the memory pool are released, the memory pool should not be
modified.

Signed-off-by: Xueshi Hu <xueshi.hu@smartx.com>
---
 drivers/md/raid1.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index dd25832eb045..ce48cb3af301 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -3298,6 +3298,13 @@ static int raid1_reshape(struct mddev *mddev)
 
 	freeze_array(conf, 0);
 
+	if (unlikely(atomic_read(conf->nr_queued))) {
+		kfree(newpoolinfo);
+		mempool_exit(&newpool);
+		unfreeze_array(conf);
+		return -EBUSY;
+	}
+
 	/* ok, everything is stopped */
 	oldpool = conf->r1bio_pool;
 	conf->r1bio_pool = newpool;
-- 
2.40.1


  reply	other threads:[~2023-07-09 10:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-09 10:29 [PATCH v2 0/3] md/raid1: don't change mempool if in-flight r1bio exists Xueshi Hu
2023-07-09 10:29 ` Xueshi Hu [this message]
2023-07-11 12:35   ` [PATCH v2 1/3] md/raid1: gave up reshape in case there's queued io Yu Kuai
2023-07-09 10:29 ` [PATCH v2 2/3] md/raid1: free old r1bio before retry write Xueshi Hu
2023-07-11 12:36   ` Yu Kuai
2023-07-09 10:29 ` [PATCH v2 3/3] md/raid1: keep holding the barrier in handle_read_error() Xueshi Hu
2023-07-11 12:37   ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230709102956.1716708-2-hubachelar@gmail.com \
    --to=xueshi.hu@smartx.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).