From: Xueshi Hu <xueshi.hu@smartx.com>
To: song@kernel.org
Cc: linux-raid@vger.kernel.org, Xueshi Hu <xueshi.hu@smartx.com>
Subject: [PATCH v2 2/3] md/raid1: free old r1bio before retry write
Date: Sun, 9 Jul 2023 18:29:55 +0800 [thread overview]
Message-ID: <20230709102956.1716708-3-hubachelar@gmail.com> (raw)
In-Reply-To: <20230709102956.1716708-1-hubachelar@gmail.com>
From: Xueshi Hu <xueshi.hu@smartx.com>
allow_barrier() make reshape possible. Raid reshape changes the
r1conf::raid_disks and mempool, so free the old r1bio and alloc a new one
when retry write.
Signed-off-by: Xueshi Hu <xueshi.hu@smartx.com>
---
drivers/md/raid1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index ce48cb3af301..6c54786067b4 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1373,6 +1373,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio,
return;
}
+ retry_write:
r1_bio = alloc_r1bio(mddev, bio);
r1_bio->sectors = max_write_sectors;
@@ -1388,7 +1389,6 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio,
*/
disks = conf->raid_disks * 2;
- retry_write:
blocked_rdev = NULL;
rcu_read_lock();
max_sectors = r1_bio->sectors;
@@ -1468,7 +1468,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio,
for (j = 0; j < i; j++)
if (r1_bio->bios[j])
rdev_dec_pending(conf->mirrors[j].rdev, mddev);
- r1_bio->state = 0;
+ free_r1bio(r1_bio);
allow_barrier(conf, bio->bi_iter.bi_sector);
if (bio->bi_opf & REQ_NOWAIT) {
--
2.40.1
next prev parent reply other threads:[~2023-07-09 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 10:29 [PATCH v2 0/3] md/raid1: don't change mempool if in-flight r1bio exists Xueshi Hu
2023-07-09 10:29 ` [PATCH v2 1/3] md/raid1: gave up reshape in case there's queued io Xueshi Hu
2023-07-11 12:35 ` Yu Kuai
2023-07-09 10:29 ` Xueshi Hu [this message]
2023-07-11 12:36 ` [PATCH v2 2/3] md/raid1: free old r1bio before retry write Yu Kuai
2023-07-09 10:29 ` [PATCH v2 3/3] md/raid1: keep holding the barrier in handle_read_error() Xueshi Hu
2023-07-11 12:37 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230709102956.1716708-3-hubachelar@gmail.com \
--to=xueshi.hu@smartx.com \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).