From: Jan Kara <jack@suse.cz>
To: Song Liu <song@kernel.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-raid@vger.kernel.org
Subject: Re: [PATCH 11/29] md: Convert to bdev_open_by_dev()
Date: Mon, 14 Aug 2023 15:37:49 +0200 [thread overview]
Message-ID: <20230814133749.yqcgmcuo5xkvlxyc@quack3> (raw)
In-Reply-To: <CAPhsuW5S2gjPv+UpLjX=uBhsbPOmNGMbGjF2eJO7rWMnGVgOmg@mail.gmail.com>
On Sun 13-08-23 19:54:56, Song Liu wrote:
> On Fri, Aug 11, 2023 at 3:05 PM Jan Kara <jack@suse.cz> wrote:
> [...]
> > diff --git a/drivers/md/md.h b/drivers/md/md.h
> > index 1aef86bf3fc3..e8108845157b 100644
> > --- a/drivers/md/md.h
> > +++ b/drivers/md/md.h
> > @@ -59,6 +59,7 @@ struct md_rdev {
> > */
> > struct block_device *meta_bdev;
> > struct block_device *bdev; /* block device handle */
> > + struct bdev_handle *bdev_handle; /* Handle from open for bdev */
>
> With bdev_handle, we should eventually get rid of md_rdev->bdev.
> But that can be done in a separate patch.
Yeah, we can do that. But in the case of md it would cause a relatively
large amount of churn so at least for this series I've stayed with the
minimal solution.
> Acked-by: Song Liu <song@kernel.org>
Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-08-14 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 11:04 [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle Jan Kara
2023-08-11 11:04 ` [PATCH 11/29] md: Convert to bdev_open_by_dev() Jan Kara
2023-08-13 15:54 ` Song Liu
2023-08-14 13:37 ` Jan Kara [this message]
2023-08-11 12:27 ` [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle Christoph Hellwig
2023-08-25 1:58 ` Al Viro
2023-08-25 13:47 ` Jan Kara
2023-08-26 2:28 ` Al Viro
2023-08-28 14:27 ` Christoph Hellwig
2023-08-28 13:20 ` Christian Brauner
2023-08-28 14:22 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-08-23 10:48 [PATCH v3 " Jan Kara
2023-08-23 10:48 ` [PATCH 11/29] md: Convert to bdev_open_by_dev() Jan Kara
2023-08-25 12:09 ` Christian Brauner
2023-09-27 9:34 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814133749.yqcgmcuo5xkvlxyc@quack3 \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox