From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] restripe.c: Use _FILE_OFFSET_BITS to enable largefile support
Date: Wed, 23 Aug 2023 14:52:56 +0200 [thread overview]
Message-ID: <20230823145256.00001103@linux.intel.com> (raw)
In-Reply-To: <20221110225546.337164-1-raj.khem@gmail.com>
On Thu, 10 Nov 2022 14:55:46 -0800
Khem Raj <raj.khem@gmail.com> wrote:
> Instead of using the lseek64 and friends, its better to enable it via
> the feature macro _FILE_OFFSET_BITS = 64 and let the C library deal with
> the width of types
>
LGTM. There are several style issues but you are not an author of them so I see
this as good to go.
Sorry, for long response time, I totally lost this one.
Acked-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
next prev parent reply other threads:[~2023-08-23 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 22:55 [PATCH] restripe.c: Use _FILE_OFFSET_BITS to enable largefile support Khem Raj
2023-08-23 12:52 ` Mariusz Tkaczyk [this message]
2024-02-20 13:02 ` Mariusz Tkaczyk
-- strict thread matches above, loose matches on Subject: below --
2024-02-20 16:51 Khem Raj
2024-02-23 8:06 ` Mariusz Tkaczyk
2022-11-10 20:45 Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823145256.00001103@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).