linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] mdadm/tests: Don't run mknod before losetup
@ 2023-09-08  8:44 Xiao Ni
  0 siblings, 0 replies; only message in thread
From: Xiao Ni @ 2023-09-08  8:44 UTC (permalink / raw)
  To: jes; +Cc: linux-raid

Sometimes it can fail:
losetup: /var/tmp/mdtest0: failed to set up loop device: No such device or address
/dev/loop0 and /var/tmp/mdtest0 are already created before losetup.

Because losetup can create device node by itself. So remove mknod.

Signed-off-by: Xiao Ni <xni@redhat.com>
---
 tests/func.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/func.sh b/tests/func.sh
index 9710a53b8a73..5053b0121f1d 100644
--- a/tests/func.sh
+++ b/tests/func.sh
@@ -170,7 +170,6 @@ do_setup() {
 				dd if=/dev/zero of=$targetdir/mdtest$d count=$sz bs=1K > /dev/null 2>&1
 			# make sure udev doesn't touch
 			mdadm --zero $targetdir/mdtest$d 2> /dev/null
-			[ -b /dev/loop$d ] || mknod /dev/loop$d b 7 $d
 			if [ $d -eq 7 ]
 			then
 				losetup /dev/loop$d $targetdir/mdtest6 # for multipath use
-- 
2.32.0 (Apple Git-132)


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-08  8:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-08  8:44 [PATCH 1/1] mdadm/tests: Don't run mknod before losetup Xiao Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).