From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: song@kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH -next] md: simplify md_seq_ops
Date: Wed, 13 Sep 2023 12:32:22 +0200 [thread overview]
Message-ID: <20230913123222.00006a8e@linux.intel.com> (raw)
In-Reply-To: <b2754d8e-dfe7-ffff-66ac-052f366530e4@huaweicloud.com>
On Tue, 12 Sep 2023 09:02:19 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:
> >> +static void *md_seq_next(struct seq_file *seq, void *v, loff_t *pos)
> >> +{
> >> + return seq_list_next(v, &all_mddevs, pos);
> >> +}
> > Can it be so simple? Why previous versions takes care of holding "(void)*1"
> > and "(void)*2" then? Could you elaborate?
>
> "1" means printing "Personalities", which is now moved to md_seq_start,
> and "2" means printing "unsed devices" which is now moved to
> md_seq_stop. And now md_seq_next is only used to iterate the mddev list.
>
Ok, LGTM.
Mariusz
next prev parent reply other threads:[~2023-09-13 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 6:50 [PATCH -next] md: simplify md_seq_ops Yu Kuai
2023-09-11 14:05 ` Mariusz Tkaczyk
2023-09-12 1:02 ` Yu Kuai
2023-09-13 10:32 ` Mariusz Tkaczyk [this message]
2023-09-22 21:22 ` Song Liu
2023-09-25 1:07 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913123222.00006a8e@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).