From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Xiao Ni <xni@redhat.com>
Cc: jes@trained-monkey.org, linux-raid@vger.kernel.org
Subject: Re: [PATCH 2/4 v2] mdadm/tests: Don't run mknod before losetup
Date: Thu, 28 Sep 2023 11:27:52 +0200 [thread overview]
Message-ID: <20230928112752.0000135b@linux.intel.com> (raw)
In-Reply-To: <20230927025219.49915-3-xni@redhat.com>
On Wed, 27 Sep 2023 10:52:17 +0800
Xiao Ni <xni@redhat.com> wrote:
> Sometimes it can fail:
> losetup: /var/tmp/mdtest0: failed to set up loop device: No such device or
> address /dev/loop0 and /var/tmp/mdtest0 are already created before losetup.
>
> Because losetup can create device node by itself. So remove mknod.
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
> tests/func.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/func.sh b/tests/func.sh
> index 9710a53b8a73..5053b0121f1d 100644
> --- a/tests/func.sh
> +++ b/tests/func.sh
> @@ -170,7 +170,6 @@ do_setup() {
> dd if=/dev/zero of=$targetdir/mdtest$d
> count=$sz bs=1K > /dev/null 2>&1 # make sure udev doesn't touch
> mdadm --zero $targetdir/mdtest$d 2> /dev/null
> - [ -b /dev/loop$d ] || mknod /dev/loop$d b 7 $d
> if [ $d -eq 7 ]
> then
> losetup /dev/loop$d $targetdir/mdtest6 # for
> multipath use
Hello,
Same as in previous case, it is waiting for Jes:
https://patchwork.kernel.org/project/linux-raid/patch/20230908084435.30674-1-xni@redhat.com/
I'm ignoring this one.
Reviewed-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Thanks,
Mariusz
next prev parent reply other threads:[~2023-09-28 9:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 2:52 [PATCH 0/4] mdadm: Fix some errors for regression tests and building Xiao Ni
2023-09-27 2:52 ` [PATCH 1/4 v2] mdadm/tests: Fix regular expression failure Xiao Ni
2023-09-28 9:24 ` Mariusz Tkaczyk
2023-10-07 13:35 ` Xiao Ni
2023-10-26 21:39 ` Jes Sorensen
2023-09-27 2:52 ` [PATCH 2/4 v2] mdadm/tests: Don't run mknod before losetup Xiao Ni
2023-09-28 9:27 ` Mariusz Tkaczyk [this message]
2023-10-26 21:44 ` Jes Sorensen
2023-09-27 2:52 ` [PATCH 3/4] mdadm: Avoid array bounds check of gcc Xiao Ni
2023-09-27 4:29 ` Paul Menzel
2023-09-27 5:06 ` Xiao Ni
2023-09-28 9:41 ` Mariusz Tkaczyk
2023-10-07 13:26 ` Xiao Ni
2023-10-09 7:59 ` Mariusz Tkaczyk
2023-09-27 2:52 ` [PATCH 4/4] mdadm: Print version to stdout Xiao Ni
2023-09-28 9:53 ` Mariusz Tkaczyk
2023-10-07 12:58 ` Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928112752.0000135b@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).