From: Paul E Luse <paul.e.luse@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Yiming Xu <teddyxym@outlook.com>,
song@kernel.org, linux-raid@vger.kernel.org,
paul.e.luse@intel.com, firnyee@gmail.com
Subject: Re: [RFC] md/raid5: optimize RAID5 performance.
Date: Mon, 27 Nov 2023 04:21:48 -0800 [thread overview]
Message-ID: <20231127042148.3b9bee3f@peluse-desk5> (raw)
In-Reply-To: <ZWQ63SpjIE4bc+pi@infradead.org>
On Sun, 26 Nov 2023 22:44:45 -0800
Christoph Hellwig <hch@infradead.org> wrote:
> Hi Shushu,
>
> the work certainly looks interesting!
>
> However:
>
> > Optimized by using fine-grained locks, customized data structures,
> > and scattered address space. Achieves significant improvements in
> > both throughput and latency.
>
> this is a lot of work for a single Linux patch, we usually do that
> work pice by pice instead of complete rewrite, and for such
> signigicant changes the commit logs also tend to be a bit extensive.
>
> I'm also not quite sure what scattered address spaces are - I bet
> reading the paper (I plan to get to that) would explain it, but it
> also helps to explain the idea in the commit message.
>
> That's my high level nitpicking for now, I'll try to read the paper
> and the patch in detail and come back later.
>
>
For sure the paper provides a lot more context. Is there more
performance data avialble, like a general sweep of various IO sizes,
patterns and queue depths? ALso, what kind of data integrity testing
has been done?
next prev parent reply other threads:[~2023-11-27 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 8:09 [RFC] md/raid5: optimize RAID5 performance Yiming Xu
2023-11-27 6:44 ` Christoph Hellwig
2023-11-27 12:21 ` Paul E Luse [this message]
2023-11-27 23:21 ` Song Liu
2024-01-16 8:31 ` Paul E Luse
2024-01-17 16:34 ` Paul E Luse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127042148.3b9bee3f@peluse-desk5 \
--to=paul.e.luse@linux.intel.com \
--cc=firnyee@gmail.com \
--cc=hch@infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=paul.e.luse@intel.com \
--cc=song@kernel.org \
--cc=teddyxym@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox