Re: [PATCH] Revert "raid: Remove now superfluous sentinel element from ctl_table array"

[Joel Granados <j.granados@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 2722 bytes --]

On Sat, Dec 23, 2023 at 08:42:35PM +0800, Coly Li wrote:
> 
> 
> > 2023年12月23日 20:25，Joel Granados <j.granados@samsung.com> 写道：
> > 
> > On Fri, Dec 22, 2023 at 09:31:18AM -0800, Luis Chamberlain wrote:
> >> On Fri, Dec 22, 2023 at 06:17:47PM +0800, Coly Li wrote:
> >>> 
> >>> 
> >>>> 2023年12月22日 03:17，Luis Chamberlain <mcgrof@kernel.org> 写道：
> >>>> 
> >>>> On Thu, Dec 21, 2023 at 02:19:56PM +0800, Yu Kuai wrote:
> >>>>> I can't find this by code review, and I think
> >>>>> maybe it's better to fix this in sysctl error path.
> >>>> 
> >>>> Indeed, we want to fix anything in the way to remove the empty sentinel,
> >>>> we continue to do that in queued work on sysctl-next [0]. Although I
> >>>> won't be able to diagnose this right away, could you try the out of
> >>>> bounds fix by Joel [1] instead?
> >>>> 
> >>>> We want to identify what caused this and fix it within sysctl code.
> >>>> 
> >>>> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next
> >>>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?h=sysctl-next&id=fd696ee2395755a292f7d49bf4c701a5bab2f076
> >>> 
> >>> Hi Luis,
> >>> 
> >>> Thanks of the above information. IMHO your code is good, When I cherry
> >>> pick the upstream md code for testing, the sysctl related change
> >>> leaked from my eyes. please ignore my noise. 
> > 
> > So this was triggered because the tree was missing the changes that
> > actually handled the removal of the sentinel?
> > 
> 
> It was from a regular update of the subsystem I maintainer for our own
> product. This is quite common to happen when a tree wide changes
> happen and subsystem maintainers of downstream products were not aware
> of the changes out of the subsystem.
> 
> Just as I said, please ignore the noise.
> 
> How to avoid such unnecessary noise? Maybe the patches to subsystems
> should add more information about the tree wide changes, e.g. this
> patch goes with the core change of xxx, when you pick it for backport
> please also be aware of the changes in xxxx.

I'll take this into account for what is missing from the sentinel
changes. It is good to leave breadcrumbs in the commit.

Thx for the suggestion. Just have to remember to do it when I post it.

Best
> 
> But this is suggestion and not mandatory, finally the developer who
> partially picked patches for  his backport will find out where he made
> mistake. Just like this time.
> 
> 
> > Get back to me if the oops persists even after you have included the
> > changes in sysctl-next
> 
> Thanks for the help. I do appreciate :-)
> 
> Coly Li

-- 

Joel Granados

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]