From: Mateusz Kusiak <mateusz.kusiak@intel.com>
To: linux-raid@vger.kernel.org
Cc: jes@trained-monkey.org, mariusz.tkaczyk@linux.intel.com
Subject: [PATCH 6/8] super-intel: Remove inaccessible code
Date: Tue, 16 Jan 2024 12:24:32 +0100 [thread overview]
Message-ID: <20240116112434.30705-7-mateusz.kusiak@intel.com> (raw)
In-Reply-To: <20240116112434.30705-1-mateusz.kusiak@intel.com>
Remove inaccessible "if" statement from imsm_set_array_state().
Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
---
super-intel.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index b4cea60f060a..a3588f2ed4c1 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -8738,23 +8738,6 @@ static int imsm_set_array_state(struct active_array *a, int consistent)
/* still reshaping, maybe update vol_curr_migr_unit */
goto mark_checkpoint;
} else {
- if (a->last_checkpoint == 0 && a->prev_action == reshape) {
- /* for some reason we aborted the reshape.
- *
- * disable automatic metadata rollback
- * user action is required to recover process
- */
- if (0) {
- struct imsm_map *map2 =
- get_imsm_map(dev, MAP_1);
- dev->vol.migr_state = 0;
- set_migr_type(dev, 0);
- set_vol_curr_migr_unit(dev, 0);
- memcpy(map, map2,
- sizeof_imsm_map(map2));
- super->updates_pending++;
- }
- }
if (a->last_checkpoint >= a->info.component_size) {
unsigned long long array_blocks;
int used_disks;
--
2.35.3
next prev parent reply other threads:[~2024-01-16 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 11:24 [PATCH 0/8] Fix checkpointing Mateusz Kusiak
2024-01-16 11:24 ` [PATCH 1/8] Remove hardcoded checkpoint interval checking Mateusz Kusiak
2024-01-16 11:24 ` [PATCH 2/8] monitor: refactor checkpoint update Mateusz Kusiak
2024-01-16 11:24 ` [PATCH 3/8] Super-intel: Fix first checkpoint restart Mateusz Kusiak
2024-01-16 11:24 ` [PATCH 4/8] Define sysfs max buffer size Mateusz Kusiak
2024-01-16 11:24 ` [PATCH 5/8] Replace "none" with macro Mateusz Kusiak
2024-01-16 11:24 ` Mateusz Kusiak [this message]
2024-01-16 11:24 ` [PATCH 7/8] Grow: Move update_tail assign to Grow_reshape() Mateusz Kusiak
2024-01-16 11:24 ` [PATCH 8/8] Add understanding output section in man Mateusz Kusiak
2024-01-17 8:02 ` [PATCH 0/8] Fix checkpointing Mariusz Tkaczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116112434.30705-7-mateusz.kusiak@intel.com \
--to=mateusz.kusiak@intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.tkaczyk@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).