From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: jes@trained-monkey.org
Cc: linux-raid@vger.kernel.org, Stefan Fleischmann <sfle@kth.se>
Subject: Re: [PATCH] super1: remove support for name= in config
Date: Fri, 9 Feb 2024 09:11:08 +0100 [thread overview]
Message-ID: <20240209091108.00006d67@linux.intel.com> (raw)
In-Reply-To: <20240201113241.26479-1-mariusz.tkaczyk@linux.intel.com>
On Thu, 1 Feb 2024 12:32:41 +0100
Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:
> Only super1 provides "name=" to config. It is recoreded in metadata
> so there is no need to duplicate same information.
> UUID is our main key.
>
> It is not used by Incremental and Assemble handles empty name well
> because other supertypes don't set it in conf.
>
> Expectation that the name in config is same as in metadata is bug prone.
> Config should be the place where use can define customized settings.
>
> Remove printing "name=" from mdadm config creation commands. Ignore
> the name in config file to keep backward compatibility. Remove
> description from man mdadm.conf.
>
> Update 00conftest because "name" is no longer accepted.
> As the name is ignored, error for mdadm --detail is not printed.
>
> Reported-by: Stefan Fleischmann <sfle@kth.se>
> Fixes: e2eb503bd797 ("mdadm: Follow POSIX Portable Character Set")
> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
No comments, Applied!
Thanks,
Mariusz
prev parent reply other threads:[~2024-02-09 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 11:32 [PATCH] super1: remove support for name= in config Mariusz Tkaczyk
2024-02-09 8:11 ` Mariusz Tkaczyk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209091108.00006d67@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
--cc=sfle@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).