linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] mdadm: fix update=resync regression
@ 2024-02-09 13:02 Mariusz Tkaczyk
  2024-02-13 15:18 ` Mariusz Tkaczyk
  0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Tkaczyk @ 2024-02-09 13:02 UTC (permalink / raw)
  To: jes; +Cc: linux-raid, Mariusz Tkaczyk

mdadm --assemble --update=resync started failing  with the error
"mdadm: --update=resync not understood for 1.x metadata".

It is a regression. Add omitted branch to fix error.

Resubmitted, original author is not responding.
https://lore.kernel.org/linux-raid/ZZqJlCToUS3Qrl4J@bianca.dpss.psy.unipd.it/

Fixes: 7e8daba8b793 ("super1: refactor the code for enum")
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
---
 super1.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/super1.c b/super1.c
index 5fd2228efbd6..871d19f0398c 100644
--- a/super1.c
+++ b/super1.c
@@ -1348,6 +1348,10 @@ static int update_super1(struct supertype *st, struct mdinfo *info,
 			__cpu_to_le16(info->disk.raid_disk);
 		break;
 	}
+	case UOPT_RESYNC:
+		/* make sure resync happens */
+		sb->resync_offset = 0;
+		break;
 	case UOPT_UUID:
 		copy_uuid(sb->set_uuid, info->uuid, super1.swapuuid);
 
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] mdadm: fix update=resync regression
  2024-02-09 13:02 [PATCH v2] mdadm: fix update=resync regression Mariusz Tkaczyk
@ 2024-02-13 15:18 ` Mariusz Tkaczyk
  0 siblings, 0 replies; 2+ messages in thread
From: Mariusz Tkaczyk @ 2024-02-13 15:18 UTC (permalink / raw)
  To: jes; +Cc: linux-raid

On Fri,  9 Feb 2024 14:02:16 +0100
Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:

> mdadm --assemble --update=resync started failing  with the error
> "mdadm: --update=resync not understood for 1.x metadata".
> 
> It is a regression. Add omitted branch to fix error.
> 
> Resubmitted, original author is not responding.
> https://lore.kernel.org/linux-raid/ZZqJlCToUS3Qrl4J@bianca.dpss.psy.unipd.it/
> 
> Fixes: 7e8daba8b793 ("super1: refactor the code for enum")
> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
> ---

No comments, Applied! 

Thanks,
Mariusz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-13 15:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-09 13:02 [PATCH v2] mdadm: fix update=resync regression Mariusz Tkaczyk
2024-02-13 15:18 ` Mariusz Tkaczyk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).