From: Christoph Hellwig <hch@lst.de>
To: Heming Zhao <heming.zhao@suse.com>
Cc: Christoph Hellwig <hch@lst.de>,
song@kernel.org, guoqing.jiang@linux.dev,
linux-raid@vger.kernel.org, colyli@suse.de, hare@suse.de
Subject: Re: [PATCH] md/md-bitmap: fix incorrect usage for sb_index
Date: Mon, 26 Feb 2024 12:04:14 +0100 [thread overview]
Message-ID: <20240226110414.GA28930@lst.de> (raw)
In-Reply-To: <a19824b2-f1c5-460f-9688-35d8c4c1605e@suse.com>
On Sat, Feb 24, 2024 at 04:41:43PM +0800, Heming Zhao wrote:
> maybe I misunderstood your meaning, do you mean: you don't like the design of the bitmap, and you hope/plan to drop it?
> bitmap is a journal-like stuff. we could get an idea from filesystem journal, just write data status to the bitmap area, rather than managing it in kernel memory. with this idea, writing data protection may involve more simpler code, the replay will become more complex.
The main problem with the dm-bitmap code is the way it does I/O. Using
->bmap to try to map blocks ahead is cumbersome, and unsafe in many
ways. If you want to keep the MD bitmap code alive someone needs to
rewrite it to go through the file systems read_iter/write_iter ops
and do direct I/O.
next prev parent reply other threads:[~2024-02-26 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 12:11 [PATCH] md/md-bitmap: fix incorrect usage for sb_index Heming Zhao
2024-02-23 15:37 ` Christoph Hellwig
2024-02-24 8:41 ` Heming Zhao
2024-02-26 11:04 ` Christoph Hellwig [this message]
2024-02-27 12:29 ` Heming Zhao
2024-02-26 21:43 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226110414.GA28930@lst.de \
--to=hch@lst.de \
--cc=colyli@suse.de \
--cc=guoqing.jiang@linux.dev \
--cc=hare@suse.de \
--cc=heming.zhao@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).