linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Blazej Kucman <blazej.kucman@linux.intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Blazej Kucman <blazej.kucman@intel.com>,
	mariusz.tkaczyk@linux.intel.com, jes@trained-monkey.org,
	linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/5] Add reading Opal NVMe encryption information
Date: Fri, 22 Mar 2024 12:55:32 +0100	[thread overview]
Message-ID: <20240322125243.0000544f@linux.intel.com> (raw)
In-Reply-To: <99cc0872-83f9-4c37-8050-9cbf95ace2c5@molgen.mpg.de>

Hi Paul,

thanks for your review, I sent the corrections in V2.

On Mon, 18 Mar 2024 18:56:42 +0100
Paul Menzel <pmenzel@molgen.mpg.de> wrote:

> Dear Blazej,
> 
> 
> Am 18.03.24 um 17:25 schrieb Blazej Kucman:
> > For NVMe devices with Opal support, encryption information, status
> > and ability are completed based on Opal Level 0 discovery response.
> >  
> 
> What do you mean by “are completed”?
> 
indeed, this word may not be precise, I meant "determined", I changed
it in V2.

and as for this comment
> Maybe document how to test this feature, preferebly with QEMU.

I added to patch "imsm: print disk encryption information",
example outputs for the new feature usage, for various cases, especially
SATA, it shows how it can be tested.

Thansk,
Blazej

  reply	other threads:[~2024-03-22 11:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 16:25 [PATCH 0/5] Disk encryption status handling Blazej Kucman
2024-03-18 16:25 ` [PATCH 1/5] Add reading Opal NVMe encryption information Blazej Kucman
2024-03-18 17:56   ` Paul Menzel
2024-03-22 11:55     ` Blazej Kucman [this message]
2024-03-18 16:25 ` [PATCH 2/5] Add reading SATA " Blazej Kucman
2024-03-18 16:25 ` [PATCH 3/5] Add key ENCRYPTION_NO_VERIFY to conf Blazej Kucman
2024-03-18 18:00   ` Paul Menzel
2024-03-18 16:25 ` [PATCH 4/5] imsm: print disk encryption information Blazej Kucman
2024-03-18 16:25 ` [PATCH 5/5] imsm: drive encryption policy implementation Blazej Kucman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240322125243.0000544f@linux.intel.com \
    --to=blazej.kucman@linux.intel.com \
    --cc=blazej.kucman@intel.com \
    --cc=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).