Re: [PATCH 2/5] tests/00createnames enhance

[Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>]

On Mon, 22 Apr 2024 14:57:16 +0800
Xiao Ni <xni@redhat.com> wrote:

> On Fri, Apr 19, 2024 at 5:47 PM Mariusz Tkaczyk
> <mariusz.tkaczyk@linux.intel.com> wrote:
> >
> > On Thu, 18 Apr 2024 18:23:18 +0800
> > Xiao Ni <xni@redhat.com> wrote:
> >  
> > > +     local is_super1="$(mdadm -D --export $DEVNODE_NAME | grep
> > > MD_METADATA=1.2)"  
> >
> > You can also limit this test to super-1.2 it may depend on config, so we can
> > specify metadata directly in create command (if it is not specified).  
> 
> Could you explain more? I don't catch you here.

Default metadata could be customized. At first glance, I thought
that you added this because we metadata is not specified so I checked:
	if [[ -z "$NAME" ]]; then
		mdadm -CR "$DEVNAME" -l0 -n 1 $dev0 --force
	else
		mdadm -CR "$DEVNAME" --name="$NAME" --metadata=1.2 -l0 -n 1
	$dev0 --force
        fi


It seems that I forgot to add metadata specifier in first create command. If
you have different metadata than 1.2 you can add --metadata=1.2 and then:

> > > +     local is_super1="$(mdadm -D --export $DEVNODE_NAME | grep
> > > MD_METADATA=1.2)" 

won't be needed. Do I miss something?

Thanks,
Mariusz