Move mdadm development to Github

Move mdadm development to Github

[Mariusz Tkaczyk]

Hello,
In case you didn't notice the patchset:
https://lore.kernel.org/linux-raid/20240419014839.8986-1-mariusz.tkaczyk@linux.intel.com/T/#t

For now, I didn't receive any feedback. I would love to hear you before
making it real.

Thanks,
Mariusz

Re: Move mdadm development to Github

[Phil Turmel]

Seems reasonable to me.  Likely to make it easier for new contributors.

On 4/24/24 02:41, Mariusz Tkaczyk wrote:
> Hello,
> In case you didn't notice the patchset:
> https://lore.kernel.org/linux-raid/20240419014839.8986-1-mariusz.tkaczyk@linux.intel.com/T/#t
> 
> For now, I didn't receive any feedback. I would love to hear you before
> making it real.
> 
> Thanks,
> Mariusz
> 

Re: Move mdadm development to Github

[John Stoffel]

>>>>> "Mariusz" == Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> writes:

> Hello,
> In case you didn't notice the patchset:
> https://lore.kernel.org/linux-raid/20240419014839.8986-1-mariusz.tkaczyk@linux.intel.com/T/#t

> For now, I didn't receive any feedback. I would love to hear you before
> making it real.

I'm really prefer you don't move the mailing list.  I hate reading
threads on a million different web apps.  I don't mind the
developement being there, but keeping the mailing list is better in my
mind.

Re: Move mdadm development to Github

[Paul E Luse]

On Thu, 25 Apr 2024 17:04:20 -0400
"John Stoffel" <john@stoffel.org> wrote:

> >>>>> "Mariusz" == Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
> >>>>> writes:
> 
> > Hello,
> > In case you didn't notice the patchset:
> > https://lore.kernel.org/linux-raid/20240419014839.8986-1-mariusz.tkaczyk@linux.intel.com/T/#t
> 
> > For now, I didn't receive any feedback. I would love to hear you
> > before making it real.
> 
> I'm really prefer you don't move the mailing list.  I hate reading
> threads on a million different web apps.  I don't mind the
> developement being there, but keeping the mailing list is better in my
> mind.
> 

To be clear, the mailing list is not moving.  The two main changes here
as Mariusz outlined in his email:

* The GitHub repo will be the new home of the code and should be
  considered the main repo.  The other will be kept around and also be
  kept in sync
* Instead of using the mailing list to propose patches, use GitHub Pull
  Requests. Mariusz is setting up GitHub to send an email to the mailing
  list so that everyone can still be made aware of new patches in the
  same manner as before.  Just use GitHub moving forward for actual
  code reviews.

Make sense?

-Paul



> 

Re: Move mdadm development to Github

[Wols Lists]

On 24/04/2024 13:27, Paul E Luse wrote:
> * Instead of using the mailing list to propose patches, use GitHub Pull
>    Requests. Mariusz is setting up GitHub to send an email to the mailing
>    list so that everyone can still be made aware of new patches in the
>    same manner as before.  Just use GitHub moving forward for actual
>    code reviews.

Does that mean contributors now need a github account? That won't go 
down well with some people I expect ...

Cheers,
Wol

Re: Move mdadm development to Github

[Mariusz Tkaczyk]

On Fri, 26 Apr 2024 08:27:44 +0100
Wols Lists <antlists@youngman.org.uk> wrote:

> On 24/04/2024 13:27, Paul E Luse wrote:
> > * Instead of using the mailing list to propose patches, use GitHub Pull
> >    Requests. Mariusz is setting up GitHub to send an email to the mailing
> >    list so that everyone can still be made aware of new patches in the
> >    same manner as before.  Just use GitHub moving forward for actual
> >    code reviews.  
> 
> Does that mean contributors now need a github account? That won't go 
> down well with some people I expect ...
> 
> Cheers,
> Wol

Hi Wol,

There are thousands repositories on Github you have to register to participate
and I don't believe that Linux developers may don't have Github account. It is
almost impossible to not have a need to sent something to Github.

Here some examples:
https://github.com/iovisor/bcc
https://github.com/axboe/fio
https://github.com/dracutdevs/dracut
https://github.com/util-linux/util-linux
https://github.com/bpftrace/bpftrace
https://github.com/systemd/systemd

I see this as not a problem.

Thanks,
Mariusz

Re: Move mdadm development to Github

[Christoph Hellwig]

On Fri, Apr 26, 2024 at 10:22:39AM +0200, Mariusz Tkaczyk wrote:
> There are thousands repositories on Github you have to register to participate
> and I don't believe that Linux developers may don't have Github account. It is
> almost impossible to not have a need to sent something to Github.

There's plenty of us that refuse to create an account with an evil
megacorp just to re-centralize development for no reason at all.

But hey, I'm not a major mdadmin contributor anyway.

Re: Move mdadm development to Github

[David Niklas]

On Fri, 26 Apr 2024 03:36:37 -0700
Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Apr 26, 2024 at 10:22:39AM +0200, Mariusz Tkaczyk wrote:
> > There are thousands repositories on Github you have to register to
> > participate and I don't believe that Linux developers may don't have
> > Github account. It is almost impossible to not have a need to sent
> > something to Github.  
> 
> There's plenty of us that refuse to create an account with an evil
> megacorp just to re-centralize development for no reason at all.
> 
> But hey, I'm not a major mdadmin contributor anyway.
> 

It's true that you "need" to have a github account. That being said, MS
has never been friendly to FLOSS/FOSS/OSS, only to mixed source SW. Even
through to this day. For example, WSL.

So you can certainly move main dev over there, but please keep other
places alive and well because there's literally no reason to think that
this "marriage" of MS and OSS will not be an abusive relationship. E.G.
some OSS devs have noticed AIs copying their code verbatim which then can
wind up in closed source projects.

David

Re: Move mdadm development to Github

[Yu Kuai]

Hi,

在 2024/04/26 16:22, Mariusz Tkaczyk 写道:
> On Fri, 26 Apr 2024 08:27:44 +0100
> Wols Lists <antlists@youngman.org.uk> wrote:
> 
>> On 24/04/2024 13:27, Paul E Luse wrote:
>>> * Instead of using the mailing list to propose patches, use GitHub Pull
>>>     Requests. Mariusz is setting up GitHub to send an email to the mailing
>>>     list so that everyone can still be made aware of new patches in the
>>>     same manner as before.  Just use GitHub moving forward for actual
>>>     code reviews.
>>
>> Does that mean contributors now need a github account? That won't go
>> down well with some people I expect ...
>>
>> Cheers,
>> Wol
> 
> Hi Wol,
> 
> There are thousands repositories on Github you have to register to participate
> and I don't believe that Linux developers may don't have Github account. It is
> almost impossible to not have a need to sent something to Github.

Will it still be able to send and apply patches through maillist? It's
important for us because I just can't create pr at GitHub in my
company, already tried with Paul, due to our company policy. :(
Although I can do this at home...

Thanks,
Kuai

> 
> Here some examples:
> https://github.com/iovisor/bcc
> https://github.com/axboe/fio
> https://github.com/dracutdevs/dracut
> https://github.com/util-linux/util-linux
> https://github.com/bpftrace/bpftrace
> https://github.com/systemd/systemd
> 
> I see this as not a problem.
> 
> Thanks,
> Mariusz
> 
> .
> 

Re: Move mdadm development to Github

[Hannes Reinecke]

On 4/30/24 11:26, Yu Kuai wrote:
> Hi,
> 
> 在 2024/04/26 16:22, Mariusz Tkaczyk 写道:
>> On Fri, 26 Apr 2024 08:27:44 +0100
>> Wols Lists <antlists@youngman.org.uk> wrote:
>>
>>> On 24/04/2024 13:27, Paul E Luse wrote:
>>>> * Instead of using the mailing list to propose patches, use GitHub Pull
>>>>     Requests. Mariusz is setting up GitHub to send an email to the 
>>>> mailing
>>>>     list so that everyone can still be made aware of new patches in the
>>>>     same manner as before.  Just use GitHub moving forward for actual
>>>>     code reviews.
>>>
>>> Does that mean contributors now need a github account? That won't go
>>> down well with some people I expect ...
>>>
>>> Cheers,
>>> Wol
>>
>> Hi Wol,
>>
>> There are thousands repositories on Github you have to register to 
>> participate
>> and I don't believe that Linux developers may don't have Github 
>> account. It is
>> almost impossible to not have a need to sent something to Github.
> 
> Will it still be able to send and apply patches through maillist? It's
> important for us because I just can't create pr at GitHub in my
> company, already tried with Paul, due to our company policy. :(
> Although I can do this at home...
> 
I do think this is a valid point.
(Having been in Beijing recently I do share the pain from Kuai :-)

We really should keep the mailing list alive, and enable people
to choose which interface suits them best.
I don't have a problem in switching to github as the primary
tree, but we should keep the original location intact as a
mirror and continue to allow people to use the mailing list
to send patches.

This is especially important for low-volume mailing lists,
where we have quite a few occasional contributors, and we
should strive to make it as easy (and convenient) as possible
for them.

Cheers,

Hannes
>>
>> Here some examples:
>> https://github.com/iovisor/bcc
>> https://github.com/axboe/fio
>> https://github.com/dracutdevs/dracut
>> https://github.com/util-linux/util-linux
>> https://github.com/bpftrace/bpftrace
>> https://github.com/systemd/systemd
>>
>> I see this as not a problem.
>>
>> Thanks,
>> Mariusz
>>
>> .
>>
> 
> 

Re: Move mdadm development to Github

[Wol]

On 30/04/2024 12:15, Hannes Reinecke wrote:
> We really should keep the mailing list alive, and enable people
> to choose which interface suits them best.
> I don't have a problem in switching to github as the primary
> tree, but we should keep the original location intact as a
> mirror and continue to allow people to use the mailing list
> to send patches.
> 
> This is especially important for low-volume mailing lists,
> where we have quite a few occasional contributors, and we
> should strive to make it as easy (and convenient) as possible
> for them.

Well they're planning to keep the mailing list - it isn't an mdadm list 
anyway. So long as they keep an eye on the list for list responses.

A lot of people (like me) go near github maybe once in a blue moon. 
Expecting non-dedicated developers to check regularly is a very big ask. 
Expecting reviewers to know what to do on github is a big ask!

I use github for a project, and really don't know my way around it.

Cheers,
Wol

Re: Move mdadm development to Github

[Mariusz Tkaczyk]

On Tue, 30 Apr 2024 13:15:18 +0200
Hannes Reinecke <hare@suse.de> wrote:

> On 4/30/24 11:26, Yu Kuai wrote:
> > Hi,
> > 
> > 在 2024/04/26 16:22, Mariusz Tkaczyk 写道:  
> >> On Fri, 26 Apr 2024 08:27:44 +0100
> >> Wols Lists <antlists@youngman.org.uk> wrote:
> >>  
> >>> On 24/04/2024 13:27, Paul E Luse wrote:  
> >>>> * Instead of using the mailing list to propose patches, use GitHub Pull
> >>>>     Requests. Mariusz is setting up GitHub to send an email to the 
> >>>> mailing
> >>>>     list so that everyone can still be made aware of new patches in the
> >>>>     same manner as before.  Just use GitHub moving forward for actual
> >>>>     code reviews.  
> >>>
> >>> Does that mean contributors now need a github account? That won't go
> >>> down well with some people I expect ...
> >>>
> >>> Cheers,
> >>> Wol  
> >>
> >> Hi Wol,
> >>
> >> There are thousands repositories on Github you have to register to 
> >> participate
> >> and I don't believe that Linux developers may don't have Github 
> >> account. It is
> >> almost impossible to not have a need to sent something to Github.  
> > 
> > Will it still be able to send and apply patches through maillist? It's
> > important for us because I just can't create pr at GitHub in my
> > company, already tried with Paul, due to our company policy. :(
> > Although I can do this at home...
> >   
> I do think this is a valid point.
> (Having been in Beijing recently I do share the pain from Kuai :-)
> 
> We really should keep the mailing list alive, and enable people
> to choose which interface suits them best.
> I don't have a problem in switching to github as the primary
> tree, but we should keep the original location intact as a
> mirror and continue to allow people to use the mailing list
> to send patches.
> 
> This is especially important for low-volume mailing lists,
> where we have quite a few occasional contributors, and we
> should strive to make it as easy (and convenient) as possible
> for them.
> 
> Cheers,
> 
> Hannes
> >>

That one is good. For those exceptional cases I'm totally fine to do
review on ML but I will request the justification why pull request cannot be
created. I will create pull request myself or ask someone else to do this, not
a big deal.

I will send v3.

Thanks Kuai and Hannes,
Mariusz