linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kinga Tanska <kinga.tanska@linux.intel.com>
To: Paul E Luse <paul.e.luse@linux.intel.com>,
	jes@trained-monkey.org, mariusz.tkaczyk@linux.intel.com
Cc: Kinga Stefaniuk <kinga.stefaniuk@intel.com>, linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/2] New timeout while waiting for mdmon
Date: Wed, 8 May 2024 09:22:55 +0200	[thread overview]
Message-ID: <20240508092133.00001845@intel.linux.com> (raw)
In-Reply-To: <20240506212859.4044771f@peluse-desk5>

On Mon, 6 May 2024 21:28:59 -0700
Paul E Luse <paul.e.luse@linux.intel.com> wrote:

> On Tue,  7 May 2024 05:38:54 +0200
> Kinga Stefaniuk <kinga.stefaniuk@intel.com> wrote:
> 
> > This series of patches contains adding new timeout
> > which is needed to have mdmon started completely.
> >   
> 
> Thanks Kinga!  What is the end user experience w/o this patch? (ie
> what negative impact does this patch address? mystery hang?  missing
> events?)
> 
> -Paul
> 
> > Kinga Stefaniuk (2):
> >   util.c: change devnm to const in mdmon functions
> >   Wait for mdmon when it is stared via systemd
> > 
> >  Assemble.c |  4 ++--
> >  Grow.c     |  7 ++++---
> >  mdadm.h    |  6 ++++--
> >  util.c     | 33 +++++++++++++++++++++++++++++++--
> >  4 files changed, 41 insertions(+), 9 deletions(-)
> >   
> 
> 

Hi Paul,

we have an issue for R0 - if grow is run for R0 to n-number of drives,
R0 has to move to R4, then mdmon is started for it. After that, mdadm
finishes --grow command, and systemd runs --grow-continue to have this
reshape continued for prepared array. With new kernels, we noticed that
R4 has not enough time to has mdmon started during this process, and for
this reason, the next command, --grow-continue failed.
Another problem is reboot during resync, sometimes mdmon has not
enough time to start too, and resync has been not continued after
reboot.
That's why I've proposed timeout which will address this problem.

Kinga

  reply	other threads:[~2024-05-08  7:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07  3:38 [PATCH 0/2] New timeout while waiting for mdmon Kinga Stefaniuk
2024-05-07  3:38 ` [PATCH 1/2] util.c: change devnm to const in mdmon functions Kinga Stefaniuk
2024-05-07  3:38 ` [PATCH 2/2] Wait for mdmon when it is stared via systemd Kinga Stefaniuk
2024-05-14  9:17   ` Paul Menzel
2024-05-14 10:56     ` Kinga Stefaniuk
2024-05-07  4:28 ` [PATCH 0/2] New timeout while waiting for mdmon Paul E Luse
2024-05-08  7:22   ` Kinga Tanska [this message]
2024-05-14  9:09 ` Mariusz Tkaczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240508092133.00001845@intel.linux.com \
    --to=kinga.tanska@linux.intel.com \
    --cc=jes@trained-monkey.org \
    --cc=kinga.stefaniuk@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=paul.e.luse@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).