linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Xiao Ni <xni@redhat.com>
Cc: Song Liu <song@kernel.org>,
	linux-raid@vger.kernel.org, jes@trained-monkey.org,
	yukuai1@huaweicloud.com, ncroxon@redhat.com, colyli@suse.de
Subject: Re: [PATCH 5/5] tests/01raid6integ.broken can be removed
Date: Wed, 8 May 2024 10:37:27 +0200	[thread overview]
Message-ID: <20240508103727.000017bb@linux.intel.com> (raw)
In-Reply-To: <CALTww2_T1h5HpdzmTBx8N++V5wM_s4f-o7_mBcw4N0iZ5fOixA@mail.gmail.com>

On Mon, 22 Apr 2024 21:54:14 +0800
Xiao Ni <xni@redhat.com> wrote:

> On Fri, Apr 19, 2024 at 11:58 PM Song Liu <song@kernel.org> wrote:
> >
> > On Fri, Apr 19, 2024 at 3:06 AM Mariusz Tkaczyk
> > <mariusz.tkaczyk@linux.intel.com> wrote:  
> > >
> > > On Thu, 18 Apr 2024 18:23:21 +0800
> > > Xiao Ni <xni@redhat.com> wrote:
> > >  
> > > > 01raid6integ can be run successfully with kernel 6.9.0-rc3.
> > > > So remove 01raid6integ.broken.
> > > >
> > > > Signed-off-by: Xiao Ni <xni@redhat.com>
> > > > ---  
> > > I don't follow the *.broken file concept. We could also describe that in
> > > comment in the test, so LGTM for the changes.
> > >
> > > If you want to, you can remove all *.broken files and add some comments
> > > in test instead. If we have some tests failing marked as broken long time
> > > ago, you can either remove those scenarios as we are obiously not
> > > interested in fixing those scenarios.  
> >
> > test script has options to skip broken tests (--skip-broken,
> > --skip-always-broken).
> > If we remove all the .broken files, we need to update the script to handle
> > comments in the test file.
> >
> > Thanks,
> > Song
> >  
> 
> Hi all
> 
> I'll try to fix all the broken test cases this time and remove the *.broken
> 
> Thanks
> Xiao
> 
> 

Anyway, this one removes one .broken file so applying!

Thanks,
Mariusz


      reply	other threads:[~2024-05-08  8:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 10:23 [PATCH RFC 0/5] mdadm tests fix and enhance Xiao Ni
2024-04-18 10:23 ` [PATCH 1/5] tests/test enhance Xiao Ni
2024-04-19  7:16   ` Mateusz Kusiak
2024-04-19  7:30     ` Mateusz Kusiak
2024-04-21  2:46       ` Xiao Ni
2024-04-18 10:23 ` [PATCH 2/5] tests/00createnames enhance Xiao Ni
2024-04-19  7:20   ` Mariusz Tkaczyk
2024-04-22  6:56     ` Xiao Ni
2024-04-22  7:23       ` Mariusz Tkaczyk
2024-04-19  9:47   ` Mariusz Tkaczyk
2024-04-22  6:57     ` Xiao Ni
2024-04-22 10:15       ` Mariusz Tkaczyk
2024-04-22 13:31         ` Xiao Ni
2024-04-18 10:23 ` [PATCH 3/5] tests/01r5fail enhance Xiao Ni
2024-04-19  9:57   ` Mariusz Tkaczyk
2024-05-08  8:35   ` Mariusz Tkaczyk
2024-04-18 10:23 ` [PATCH 4/5] tests/01r5integ.broken Xiao Ni
2024-05-08  8:36   ` Mariusz Tkaczyk
2024-04-18 10:23 ` [PATCH 5/5] tests/01raid6integ.broken can be removed Xiao Ni
2024-04-19 10:05   ` Mariusz Tkaczyk
2024-04-19 15:57     ` Song Liu
2024-04-22 13:54       ` Xiao Ni
2024-05-08  8:37         ` Mariusz Tkaczyk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240508103727.000017bb@linux.intel.com \
    --to=mariusz.tkaczyk@linux.intel.com \
    --cc=colyli@suse.de \
    --cc=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=ncroxon@redhat.com \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    --cc=yukuai1@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).