From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: linan666@huaweicloud.com, song@kernel.org,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.co,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] md: do not delete safemode_timer in mddev_suspend
Date: Wed, 15 May 2024 15:12:04 +0200 [thread overview]
Message-ID: <20240515151204.0000113d@linux.intel.com> (raw)
In-Reply-To: <33185f65-b657-b15b-ffa8-e35319fa0a5f@huaweicloud.com>
On Thu, 9 May 2024 09:34:15 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:
> However, since this behaviour is introduced since 2012, does anybody
> really care about array status is 'active' instead of 'clean' while
> there is no IO after suspend?
It may cause rebuild after reboot (bad but we can live with it) or platform hang
(this is bad). mdadm is waiting for transition to clean on shutdown if I
remember correctly.
Probably nobody tried that as we all know that Linux doesn't like suspending
and this is rare to reboot platform just after suspend. Probably any write will
fix it.
But this is all based on my knowledge, not tested or proved however I believe
that it gives light where to look for problems if you want.
Mariusz
next prev parent reply other threads:[~2024-05-15 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 9:20 [PATCH] md: do not delete safemode_timer in mddev_suspend linan666
2024-05-09 1:34 ` Yu Kuai
2024-05-15 13:12 ` Mariusz Tkaczyk [this message]
2024-06-10 17:35 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515151204.0000113d@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=houtao1@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.co \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).