From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Xiao Ni <xni@redhat.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/4] mdadm/tests: fix and enhance some cases
Date: Tue, 28 May 2024 17:15:59 +0200 [thread overview]
Message-ID: <20240528171559.00002f14@linux.intel.com> (raw)
In-Reply-To: <20240528135150.26823-1-xni@redhat.com>
On Tue, 28 May 2024 21:51:46 +0800
Xiao Ni <xni@redhat.com> wrote:
> Hi all
>
> This is the third patch set that fix and enhance some test cases.
Applied all. Here some minor comments:
>
> Xiao Ni (4):
> mdadm/tests: bitmap cases enhance
> mdadm/tests: 04update-uuid
you can remove testing of bitmap file.
> mdadm/tests: 05r1-re-add-nosuper
same in this test.
I missed those tests but I wrote in 50b100768a11:
"The implementation of custom bitmap file looks like it's
abandoned. It cannot be done by Incremental so it is not respected by
any udev based system and it seems to not be recorded by metadata.
User must assemble such volume manually."
I do not consider it as a real-life feature. We should help it to become
deprecated (it is in kernel) and dropping tests is reasonable for me.
Thanks for patches,
Mariusz
prev parent reply other threads:[~2024-05-28 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 13:51 [PATCH 0/4] mdadm/tests: fix and enhance some cases Xiao Ni
2024-05-28 13:51 ` [PATCH 1/4] mdadm/tests: bitmap cases enhance Xiao Ni
2024-05-28 13:51 ` [PATCH 2/4] mdadm/tests: 04update-uuid Xiao Ni
2024-05-28 13:51 ` [PATCH 3/4] mdadm/tests: 05r1-re-add-nosuper Xiao Ni
2024-05-28 13:51 ` [PATCH 4/4] mdadm/tests: remove strace test Xiao Ni
2024-05-28 15:15 ` Mariusz Tkaczyk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528171559.00002f14@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).